Conversation
Record the Flatcar binary import decision and keep the AGENTS target content aligned with the new installer/OS-payload split. Assisted-by: GPT-5.5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: castrojo <castrojo@users.noreply.github.com>
hanthor
left a comment
hanthor
left a comment
There was a problem hiding this comment.
The rule change is the right shape, and the ADR does the work an AGENTS.md one-liner can't — it names the constraint that forces it (systemd-sysinstall doesn't exist in Flatcar), names the contract that makes the split safe (CopyBlocks= is byte-level), and records both rejected alternatives. Keeping DOCUMENTATION_OVERHAUL_PLAN.md's embedded copy in sync is a nice catch.
pytest tests/unit 213 passed / 1 xfailed, docs-checks.py passed.
This must land before #132, #140 and #141. All three import Flatcar binaries into the OS payload, which rule 1 as currently written on main forbids:
1. Compose from FSDK 26.08 `components/*`. Never use `platform.bst`.
One contradiction to resolve — with #123, not with this PR
The ADR rejects "Keep the status quo hybrid" on the grounds that it "preserves the ABI split that the migration is meant to remove." #123, the design doc for this same migration, states the opposite three times — "The build base stays freedesktop-sdk 26.08. Hard rule 1 is unchanged" — and says "ABI parity is explicitly not the goal." Whichever way that lands, both documents shouldn't ship as-is. I've raised it on #123.
One gap worth closing here
The ADR says "Hard rules 2-6 are unchanged […] k0s and container runtimes stay out of the base OS DDI." But #141 adds flatcar-podman.bst, containerd-flatcar.bst and docker-flatcar.bst as runtime depends: of os-stack.bst, each doing unsquashfs -d "%{install-root}" — so all three land inside the DDI, and #141's own comment claims this "honor[s] hard rule 4."
Since this PR is where rule scope gets decided, it's the natural place to either extend the reasoning to rule 4 or state plainly that #141 doesn't satisfy it as written. Leaving rule 4 untouched while three runtimes move into the DDI underneath it just relocates the contradiction.
Minor: test_architecture_rules.py asserts on exact English substrings of AGENTS.md. That's fine for a rule this load-bearing, but a future copy-edit will break it in a way whose failure message won't explain why — a comment saying so would help.
Generated by Claude Code
Signed-off-by: castrojo <castrojo@users.noreply.github.com>
|
Addressed review feedback:
|
2 participants
Summary
Closes #124.
Validation
python3 .github/scripts/docs-checks.pyuv tool run --from pytest pytest tests/unit/test_architecture_rules.py -qjust validatereached both version checks, then stopped because this workstation lackspodmanandsudoafterXDG_RUNTIME_DIRwas redirected off read-only/run/user/1000— hive: backend=omp