review: post-merge round over the batch - #135
Merged
Merged
Conversation
ToResourcePercent divides through core's AdvancedDivide instead of a local twin; the node status command keeps its one-shot and periodic paths apart; nodePercentOf is the one place a node's percentages are computed, so the stream path no longer builds a one-element slice per node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The four
/simplifylenses over the whole batch since the last style round. Applied:ToResourcePercentdivides through core'sAdvancedDivideinstead of a local twin.node statuskeeps its one-shot and periodic paths apart: the one-shot returns its heartbeat, the periodic logs the first beat like every later one.nodePercentOfis the one place a node's percentages are computed; the stream path no longer builds a one-element slice per node.Not applied, recorded for a later batch: declaring required positionals through urfave/cli v3
cli.Argumentacross the 18 commands that hand-roll the "name must be given" check (about −54 lines; changes the error text).Lines
Production −4 net, tests unchanged; comment delta +0 −0.
Evidence
Gate on the branch: build, vet, full tests,
make lint,make fmt-checkandaslon both GOOS green.