test: pin the WAL processing replay and the AddNode cache eviction - #752
Open
CMGS wants to merge 1 commit into
Open
test: pin the WAL processing replay and the AddNode cache eviction#752CMGS wants to merge 1 commit into
CMGS wants to merge 1 commit into
Conversation
ProcessingCreatedHandler is replayed against an embedded etcd: only the abandoned processing record of the recovering instance is released, a live request of another instance keeps its count and its journal, and a second recovery has nothing left. AddNode drops the cached engine when the resource plugins refuse the node, so a retry dials again instead of reusing the stale client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test debt from the 2026-09 audit, two items:
ProcessingCreatedHandlerreplayed against an embedded etcd: one instance journals an abandoned processing record and a finished one (committed away), another instance journals a live one;DisasterRecoverreleases only the abandoned ident, the live request keeps its count and its journal, a replayed entry is dropped, and a second recovery has nothing left.AddNodedrops the cached engine when the resource plugins refuse the node, so a retry dials again instead of reusing the stale client; a successful add keeps it cached.Tests only, no production change. Gates: build, vet, full tests, lint, fmt-check, asl on linux and darwin green.