Skip to content

feat(wiki): support account-scoped grants - #27

Open
promptclickrun wants to merge 1 commit into
mainfrom
feat/wiki-account-grants
Open

promptclickrun wants to merge 1 commit into
mainfrom
feat/wiki-account-grants

Conversation

@promptclickrun

Copy link
Copy Markdown
Owner

Summary

Wiki device allowlists require another host grant whenever the same account registers a new phone or tablet.

Add explicit host-local wiki grant --account authorization for an exact root/profile. It uses the existing account-key-bound pairing authority and Link authentication instead of a Wiki device allowlist. Read-only policy, device revocation at Link, filesystem confinement, and host ownership checks stay in place.

Existing grants migrate as device-scoped without changing permissions or generations. Scope conversion is explicit, clears device IDs, and rotates the generation. In-app registration behavior and wire DTOs are unchanged. Host re-pairing/account-key rotation still requires reauthorization.

Validation

  • Red/green tests for account grants and the --account CLI.
  • Full isolated offline suite: 714 tests, 5 platform-specific skips, no failures. Baseline: 710 tests, same skips; existing ResourceWarning/deprecation warnings remain.
  • Plugin Doctor: passed runtime discovery/import/registration.
  • New-device reads after reopening the store; wrong-account ciphertext rejected through encrypted Link/adapter dispatch; foreign account/profile/stale owner denied.
  • Legacy migration, explicit scope conversion/idempotency, and read-only enforcement covered.
  • Independent security review: no blocking findings.

Account scope requires updated running processes. Older plugin code denies account grants because their device list is empty.

Authored with GPT-6 Astra through the Hermes Agent harness.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T19:02:41.398360Z 21f8439 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant