feat: ci improvement - #31
Open
dzdidi wants to merge 4 commits into
Open
Conversation
Signed-off-by: dzdidi <dzdidi@users.noreply.github.com>
ben-kaufman
reviewed
Aug 26, 2026
ben-kaufman
reviewed
Aug 26, 2026
ben-kaufman
reviewed
Aug 26, 2026
Signed-off-by: dzdidi <dzdidi@users.noreply.github.com>
Signed-off-by: dzdidi <dzdidi@users.noreply.github.com>
Signed-off-by: dzdidi <dzdidi@users.noreply.github.com>
ben-kaufman
reviewed
Aug 26, 2026
| ephemeral local PostgreSQL service. Do not claim the full suite passed when only a subset | ||
| ran. | ||
|
|
||
| `./scripts/check` preserves a caller-provided `TEST_DATABASE_URL`. When it is unset, the |
Contributor
There was a problem hiding this comment.
scripts/check still omits legacy_connect_shell_http and pubky_homeserver_repositories when TEST_DATABASE_URL is unset, even though both are non-PostgreSQL and the CI Rust lane runs them. Could we run those two unconditionally with the other E2E targets so this documented no-database path covers all non-database checks?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contract and risk impact
Verification
Documentation
Checklist