[mypyc] Propagate property setter return value - #21814
Open
p-sawicki wants to merge 6 commits into
Open
Conversation
JukkaL
reviewed
Aug 6, 2026
| f"{NATIVE_PREFIX}{func_ir.cname(emitter.names)}((PyObject *) self, value);" | ||
| f"retval = {NATIVE_PREFIX}{func_ir.cname(emitter.names)}((PyObject *) self, value);" | ||
| ) | ||
| emitter.emit_line(f"if (retval == {emitter.c_error_value(ret_type)}) return -1;") |
Collaborator
There was a problem hiding this comment.
This may not work with overlapping error values (e.g. float type). For these, we'd also need a PyErr_Occurred() check?
Collaborator
Author
There was a problem hiding this comment.
Right, property setters returning types with error overlap were still bugged. Changed to use emit_error_check which adds PyErr_Occurred when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property setter wrapper put in
tp_getsetreturns 0 regardless of the value returned by the function generated for the property setter. This can cause strange errors reported by cpython when the property setter raises an exception since the wrapper still returns a non-error value.Fix by checking the return value of the property setter in the wrapper and returning -1 on error.