Skip to content

PEP 842: New revision based on discussion feedback - #5077

Merged
ZeroIntensity merged 10 commits into
python:mainfrom
ZeroIntensity:pep-842/new-revision
Aug 7, 2026
Merged

PEP 842: New revision based on discussion feedback#5077
ZeroIntensity merged 10 commits into
python:mainfrom
ZeroIntensity:pep-842/new-revision

Conversation

@ZeroIntensity

Copy link
Copy Markdown
Member
  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

@hugovk -- Not too sure who to ping, but I added a Sphinx extension to highlight custom keywords. Is that okay? It's not too complex, and I think it makes the proposed syntax look really nice.

@ZeroIntensity
ZeroIntensity requested a review from hugovk August 5, 2026 18:51
@read-the-docs-community

read-the-docs-community Bot commented Aug 5, 2026

Copy link
Copy Markdown

@ZeroIntensity

Copy link
Copy Markdown
Member Author

Echoing what I said on DPO: If nobody has any complaints about the Sphinx plugin here, I'll merge this today or tomorrow (partially depending on when Barry posts PEP 844).

@hugovk

hugovk commented Aug 6, 2026

Copy link
Copy Markdown
Member

Can you split out the extension to another PR? Then we don't need to delay the PEP update.

Comment thread peps/pep-0842.rst Outdated
Comment thread peps/pep-0842.rst Outdated
@ZeroIntensity

Copy link
Copy Markdown
Member Author

I can, but I'm hesitant to do so, since it makes the proposed solution look pretty bad :(

image

The highlighting makes it feel way more natural.

ZeroIntensity and others added 3 commits August 6, 2026 10:24
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
For Barry to link against in PEP 844.
@ZeroIntensity

Copy link
Copy Markdown
Member Author

I'm going to try out GitHub's fancy new PR stacking thing for the Sphinx extension.

@ZeroIntensity

Copy link
Copy Markdown
Member Author

After careful analysis, it seems that it did not work at all. I'm going to merge this and put up the highlighting in a new PR.

@ZeroIntensity
ZeroIntensity enabled auto-merge (squash) August 6, 2026 19:58
@ZeroIntensity
ZeroIntensity merged commit 87d12a9 into python:main Aug 7, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants