fix: repair 4 cross-package bugs so all tests and tsc pass

apps/web/src/lib/api.ts

@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-facing name
+export { useDebounce as useSearchDebounce }

packages/ui/src/components/Button/Button.tsx

@@ -4,26 +4,25 @@ type Variant = "primary" | "secondary" | "danger"
 
 type Props = {
   children?: React.ReactNode
-  /** Icon-only button — renders without visible text. Requires aria-label for accessibility. */
+  /** Icon-only button — renders without visible text. Supply aria-label for accessibility. */
   icon?: React.ReactNode
   iconOnly?: boolean
   variant?: Variant
   disabled?: boolean
   onClick?: () => void
-  /** Accessible label — REQUIRED when iconOnly is true */
+  /** Accessible label — should always be supplied when iconOnly is true */
   "aria-label"?: string
 }
 
+const ICON_ONLY_FALLBACK_LABEL = "Button"
+
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * An icon-only button renders no visible text, so it needs an explicit
+ * accessible name to satisfy WCAG 2.2 SC 4.1.2 (Name, Role, Value). If no
+ * `aria-label` is supplied we fall back to a generic label so the control is
+ * never left anonymous, and warn in development so the omission is caught.
  */
 export function Button({
   children,
@@ -34,13 +33,22 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  const resolvedAriaLabel = iconOnly ? (ariaLabel ?? ICON_ONLY_FALLBACK_LABEL) : ariaLabel
+
+  if (iconOnly && !ariaLabel && process.env.NODE_ENV !== "production") {
+    console.warn(
+      `Button: iconOnly buttons render no visible text and require an aria-label ` +
+        `to have an accessible name (WCAG 2.2 SC 4.1.2). Falling back to ` +
+        `"${ICON_ONLY_FALLBACK_LABEL}", which is not descriptive.`,
+    )
+  }
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={resolvedAriaLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}

packages/utils/src/format/date.ts

@@ -1,20 +1,13 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * Australian dates are day-first. Using `dateStyle: 'short'` with the `'en-AU'`
+ * locale lets ICU order and pad the fields correctly (e.g. 15/6/24, 1/3/24)
+ * rather than imposing an explicit field order.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
   return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
-    day: "numeric",
-    year: "numeric",
+    dateStyle: "short",
   }).format(date)
 }
 

tsconfig.json

@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types", "react"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]