fix: repair failing tests and type errors across api and shared packages - #153
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api and shared packages#153stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- implement paginate() stub in shared/utils (was throwing not-implemented) - import missing badRequest helper in users route (was 500 instead of 400) - fix case-sensitivity bug in auth middleware public-method allow-list (POST /users is now correctly public) - rename shared User.userName -> username to match consumers and tests - add bun-types to tsconfig so bun:test and process resolve All tests pass (22/22) and tsc --noEmit is clean. No test files or dependencies changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 9 failing tests and all 14 type errors in the repo. Both gates are now green:
bun test→ 22 pass / 0 fail,bunx tsc --noEmit→ exit 0.Changes (5 files)
packages/shared/src/utils/pagination.ts— implemented thepaginate()stub that previously threw"not implemented". Slicesitemsby page/size, computestotal/totalPages, and handles empty arrays and out-of-range pages per the test contract.packages/api/src/routes/users.ts— added the missingbadRequestimport from../lib/errors. The missing import caused aReferenceError→ HTTP 500 instead of the expected 400 on invalid input.packages/api/src/middleware/auth.ts— fixed the case-sensitivity bug in the public-method allow-list ("post"never matched Hono's uppercasePOST), soPOST /usersis now correctly public. Incoming method is normalised with.toUpperCase()before comparison.packages/shared/src/types.ts— renamedUser.userName→usernameso the shared type matches its consumers (routes/users.ts,lib/db.ts) and the (unchangeable) tests. No remaininguserNamereferences in code.tsconfig.json— added"types": ["bun-types"]to resolvebun:testandprocess.bun-types@1.4.0was already a root devDependency; no new dependencies added.Constraints honoured
package.jsonchanges.Reviewer notes (non-blocking, out of scope for the failing tests)
A review pass flagged a few pre-existing / edge-case items that the tests do not require and were intentionally left as-is:
paginate()producesNaNfields for non-finitepage/sizeinput; harmless today (no callers) but worth sanitising on first real use.auth.tsuses a non-constant-time token comparison with a hardcoded fallback secret (pre-existing).POSTendpoints being public means unauthenticated writes — this is deliberate and asserted byauth.test.ts("POST /users is public").🤖 Generated with autonomous agent