Fix the descriptor checks of the Proxy getOwnPropertyDescriptor trap - #1635
Open
saghul wants to merge 1 commit into
Open
Fix the descriptor checks of the Proxy getOwnPropertyDescriptor trap#1635saghul wants to merge 1 commit into
saghul wants to merge 1 commit into
Conversation
Contributor
|
Has conflicts. General note: I keep wondering with all these obscure edge case bug reports why test262 doesn't have coverage. My preference is for people to submit a regression test upstream first. That way we can be sure it's a) an actual corner case and not some misreading of the spec, and b) whether other engines implement it correctly or not. If not all do, that's probably an indication of something. |
Contributor
Author
|
FWIW, I submitted a PR with a bunch of extra coverage for iterators and it got approved reasonably quickly, but it's still pending merge :-/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1629.