Simplified heat tests - #3484
Open
jort-wolda wants to merge 3 commits into
Open
Conversation
- Also deleted some turk_hhp queries that are not used anywhere
kndehaan
force-pushed
the
simplified-heat-tests
branch
from
September 2, 2026 12:44
31f8b13 to
395af4d
Compare
kndehaan
reviewed
Sep 2, 2026
Member
There was a problem hiding this comment.
Why is this new query required? Can the existing query costs_building_and_installations_households_insulation.gql be used for the same purpose?
Contributor
Author
There was a problem hiding this comment.
Existing query also divides the costs by the technical lifetime resulting in CAPEX/year. I thought it would be more 'clean' if it only used the CAPEX but you're right it is not necessary. I deleted them and now refer to the existing queries.
kndehaan
reviewed
Sep 2, 2026
Member
There was a problem hiding this comment.
Same question here, can the existing costs_building_and_installations_buildings_insulation.gql query be used instead of adding a new query?
And refer to the existing ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Due to simplified sliders in built environment the old spec was deleted. These are queries for the new spec.
Implemented changes
Related
Goes with pull requests
Checklist