Display uf2 combine --offset default-value in hexadecimal - #353
Conversation
| ( | ||
| option("--offset").set(settings.uf2.offset_set) % "Offset second UF2 by amount" & | ||
| hex("offset").set(settings.uf2.offset) % "offset amount (default to 0)" | ||
| hex("offset").set(settings.uf2.offset) % "offset amount (default to 0x0)" |
There was a problem hiding this comment.
Maybe worth explicitly mentioning it is hexadecimal too?
| hex("offset").set(settings.uf2.offset) % "offset amount (default to 0x0)" | |
| hex("offset").set(settings.uf2.offset) % "offset amount (hexadecimal, default to 0x0)" |
There was a problem hiding this comment.
Sorry, I somehow completely missed this comment! 🤦 (must have got buried under all my other GH notifications)
I've no objections to this, but note that there's many other example / default values listed in https://github.com/raspberrypi/picotool/blob/develop/README.md that start with 0x and that aren't explicitly stated to be hexadecimal.
There was a problem hiding this comment.
Most of those either say memory address (or similar), or are integer() command line options (which accept hex or non-hex values)
I think the only hex() options that don't explicitly say memory address or hexadecimal are:
--rollbackrows - could change toAdd Rollback Version, optionally specifying rollback rows in hex--pad- could change toSpecify alignment to pad to (hexadecimal; default 0x1000)--abs-blockabs_block_loc - could change to(memory address; default 0x10ffff00)
There was a problem hiding this comment.
Sounds good to me - feel free to make whatever changes you want to this PR 🙂 (and then merge it when you're happy)
Co-authored-by: will-v-pi <108662275+will-v-pi@users.noreply.github.com>
2 participants
Possible fix for #352