fix: include exact gestational chart boundaries - #101
Open
pacharanero wants to merge 1 commit into
Open
Conversation
Member
Author
|
@eatyourpeas this is a question for you really. I'm reviewing as much of the dGC Python/API/Chart/Demo code as possible, bit by bit. Where I find possible inconsistencies I'm flagging them, in case they were not deliberate. This one could have been deliberate - if it was then that's fine we can close the PR and make some comments in the code that explain the decision. |
Member
|
I am not sure i understand this but yes, 25 weeks should be exactly 25 weeks and so on. It is important that the charting allows plotting of values below these gestations as babies these days are born and save at 22 w, so they need to be plottable even if there is no reference data down there to generate and SDS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clinical/reference-data question
Should UK-WHO charts include the exact first valid points at 23 weeks for weight and head circumference, 25 weeks for height, and 42 weeks for infant BMI?
The current chart age arrays use rounded decimal-year values that are fractionally below those exact thresholds. Validation therefore rejects the points even though data below the thresholds remains deliberately unsupported.
Proposed fix
Clinical safety
This does not extrapolate reference data or expand the supported gestational range. It restores only the exact valid boundary points using the existing reference calculations.
Testing
docker run --rm rcpchgrowth-exact-chart-boundaries-rcpchgrowth-python pytest