fix(ios): validate packager messages before parsing - #57844
fix(ios): validate packager messages before parsing#57844JoaoPauloCMarra wants to merge 1 commit into
Conversation
|
Hi @JoaoPauloCMarra! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
SocketRocket can deliver binary WebSocket payloads, and RCTJSONParse can return valid JSON fragments. Guard both cases before the iOS dev-support packager connection accesses protocol fields.
Changelog:
[IOS] [FIXED] - Prevent crashes when iOS dev support receives non-object packager messages.
Test Plan:
xcodebuild test -workspace RNTesterPods.xcworkspace -scheme RNTester -sdk iphonesimulator -destination "id=25B49671-6960-4F09-AEF7-35E45A0D39CD" -derivedDataPath /tmp/RNTesterBuild -only-testing:RNTesterUnitTests/RCTPackagerConnectionTestsyarn lint