Align attributions with the deltasignal paraphrases; remove home paths - #95
Merged
Merged
Conversation
The two repos had drifted apart. deltasignal #63 paraphrased two requirement sentences out of verbatim quotation, and this repo still carried the same two sentences quoted verbatim -- so the record said different things about the same requirement in two places, which is what makes a record untrustworthy later. Paraphrased here to match: src/diagram_connectivity.py (the two-glyphs-same- compartment requirement) and src/resolution_validation.py (the both-directions mapping requirement), plus three name attributions in specs/001-validator-fidelity/spec.md, src/logic_network_generator.py and tests/test_provenance_exports.py. Technical content unchanged; only the quoting and the attribution-by-name went. The pyproject.toml authorship line stays. Home paths gone: both bin/ scripts hardcoded /home/awright/gitroot/mp-biopath-pathways, now MPBIO_ROOT with a ~/gitroot default, matching the convention the deltasignal bench scripts use. NOT changed, deliberately: docker-compose.yml publishes Neo4j on all interfaces with image-default auth. I had flagged that as an exposure and it is not one -- the image is public.ecr.aws/reactome/graphdb, i.e. Reactome own publicly distributed database, so there is no confidentiality impact, and publishing the ports is the point of the file. The credential literals in three tests authenticate against that same public database. 1036 passed, 1 pre-existing MHC failure; ruff and mypy clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to deltasignal #63, which paraphrased verbatim quotes out of that repo. This repo still carried the same two requirement sentences quoted verbatim, so the record said different things about the same requirement in two places — the kind of drift that makes a record untrustworthy later.
Aligned
src/diagram_connectivity.pysrc/resolution_validation.pyspecs/001-validator-fidelity/spec.md## Architecture principle (Adam, 2026-09)+ a blockquote of first-person speechsrc/logic_network_generator.pytests/test_provenance_exports.pyTechnical content unchanged — only the quoting and the attribution-by-name. The
pyproject.tomlauthorship line stays.Home paths
Both
bin/scripts hardcoded/home/awright/gitroot/mp-biopath-pathways. NowMPBIO_ROOTwith a~/gitrootdefault, matching the convention the deltasignal bench scripts already use.git grep -E "/home/|/Users/"is empty.Not changed, deliberately
docker-compose.ymlpublishes Neo4j on 7474/7687 across all interfaces with image-default auth. I previously flagged this as an exposure and it is not one. The image ispublic.ecr.aws/reactome/graphdb— Reactome's own publicly distributed database — so there is no confidentiality impact, and publishing the ports is the entire point of the file. The credential literals in three tests authenticate against that same public database.Verification
pytestruff check src/ bin/mypy src/git grep -I "Adam"git grep -E "/home/|/Users/"Noted, not touched
bin/check-no-path-cases-in-neo4j.py:42reads a hardcoded/tmp/mpbio_pathways.tsvthat must be pre-created. A latent fragility rather than a hygiene issue, and out of scope here.🤖 Generated with Claude Code