Skip to content

Align attributions with the deltasignal paraphrases; remove home paths - #95

Merged
adamjohnwright merged 1 commit into
mainfrom
chore/align-attributions-and-paths
Sep 22, 2026
Merged

adamjohnwright merged 1 commit into
mainfrom
chore/align-attributions-and-paths

Conversation

@adamjohnwright

Copy link
Copy Markdown
Contributor

Follow-up to deltasignal #63, which paraphrased verbatim quotes out of that repo. This repo still carried the same two requirement sentences quoted verbatim, so the record said different things about the same requirement in two places — the kind of drift that makes a record untrustworthy later.

Aligned

file was
src/diagram_connectivity.py verbatim quote of the two-glyphs-in-one-compartment requirement
src/resolution_validation.py verbatim quote of the both-directions mapping requirement
specs/001-validator-fidelity/spec.md ## Architecture principle (Adam, 2026-09) + a blockquote of first-person speech
src/logic_network_generator.py "Rule (per Adam)"
tests/test_provenance_exports.py "the invariant behind Adam's question"

Technical content unchanged — only the quoting and the attribution-by-name. The pyproject.toml authorship line stays.

Home paths

Both bin/ scripts hardcoded /home/awright/gitroot/mp-biopath-pathways. Now MPBIO_ROOT with a ~/gitroot default, matching the convention the deltasignal bench scripts already use. git grep -E "/home/|/Users/" is empty.

Not changed, deliberately

docker-compose.yml publishes Neo4j on 7474/7687 across all interfaces with image-default auth. I previously flagged this as an exposure and it is not one. The image is public.ecr.aws/reactome/graphdb — Reactome's own publicly distributed database — so there is no confidentiality impact, and publishing the ports is the entire point of the file. The credential literals in three tests authenticate against that same public database.

Verification

check result
pytest 1036 passed, 1 pre-existing MHC failure
ruff check src/ bin/ clean
mypy src/ clean
git grep -I "Adam" 1, the authorship line
git grep -E "/home/|/Users/" empty

Noted, not touched

bin/check-no-path-cases-in-neo4j.py:42 reads a hardcoded /tmp/mpbio_pathways.tsv that must be pre-created. A latent fragility rather than a hygiene issue, and out of scope here.

🤖 Generated with Claude Code

The two repos had drifted apart. deltasignal #63 paraphrased two requirement
sentences out of verbatim quotation, and this repo still carried the same two
sentences quoted verbatim -- so the record said different things about the same
requirement in two places, which is what makes a record untrustworthy later.

Paraphrased here to match: src/diagram_connectivity.py (the two-glyphs-same-
compartment requirement) and src/resolution_validation.py (the both-directions
mapping requirement), plus three name attributions in
specs/001-validator-fidelity/spec.md, src/logic_network_generator.py and
tests/test_provenance_exports.py. Technical content unchanged; only the quoting
and the attribution-by-name went. The pyproject.toml authorship line stays.

Home paths gone: both bin/ scripts hardcoded
/home/awright/gitroot/mp-biopath-pathways, now MPBIO_ROOT with a ~/gitroot
default, matching the convention the deltasignal bench scripts use.

NOT changed, deliberately: docker-compose.yml publishes Neo4j on all
interfaces with image-default auth. I had flagged that as an exposure and it is
not one -- the image is public.ecr.aws/reactome/graphdb, i.e. Reactome own
publicly distributed database, so there is no confidentiality impact, and
publishing the ports is the point of the file. The credential literals in three
tests authenticate against that same public database.

1036 passed, 1 pre-existing MHC failure; ruff and mypy clean.
@adamjohnwright
adamjohnwright merged commit 86ec06d into main Sep 22, 2026
4 checks passed
@adamjohnwright
adamjohnwright deleted the chore/align-attributions-and-paths branch September 22, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant