Skip to content

COR-181 - Make MailCore2 independent from AWS - #104

Merged
dbezverkhnii merged 3 commits into
spark2from
feature/COR-181-make-mailcore2-independent-from-aws
Sep 1, 2026
Merged

COR-181 - Make MailCore2 independent from AWS#104
dbezverkhnii merged 3 commits into
spark2from
feature/COR-181-make-mailcore2-independent-from-aws

Conversation

@dbezverkhnii

@dbezverkhnii dbezverkhnii commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Changes how all Windows Spark consumers fetch MailCore C++ binaries; a missing or mismatched release asset breaks Windows builds until someone publishes from a Windows machine with gh auth.

Overview
Replaces the Spark Windows MailCore prebuilt pipeline so artifacts and binary deps no longer use the spark-prebuilt-binaries S3 bucket or SPARK_PREBUILT_KEY. Prebuilts are mailcore2-windows-<digest>.zip on the permanent windows-prebuilt GitHub release; openssl/sasl/zlib come from mailcore2-windows-deps-1.zip on the same release.

The digest is derived from git tree entries over src (excluding src/swift), CMakeLists.txt, and build-windows-5.10, so checkouts pick the right archive without bumping $PrebuiltMailcoreVersion in Get-Mailcore2.ps1. Publish-Mailcore2Prebuilt.ps1 builds, stamps etc/mailcore2-source-digest, verifies the package, and uploads via gh. Get-Mailcore2.ps1 downloads publicly, treats only HTTP 404 as “missing prebuilt”, and rejects archives whose stamped digest does not match.

A new pull-request job (mailcore2 - Windows prebuilt on Ubuntu) runs Check-PrebuiltPublished.ps1 against the merge commit so a forgotten publish fails in the PR (including rebase hints when the branch head already has an archive). README.md and new AGENTS.md document publish and check behavior.

Reviewed by Cursor Bugbot for commit e44c2f7. Bugbot is set up for automated code reviews on this repo. Configure here.

lxbndr
lxbndr previously approved these changes Sep 1, 2026
Comment thread build-windows-5.10/Get-Mailcore2.ps1
@dbezverkhnii
dbezverkhnii requested a review from lxbndr September 1, 2026 16:15
@dbezverkhnii
dbezverkhnii merged commit 147acf5 into spark2 Sep 1, 2026
9 of 10 checks passed
@dbezverkhnii
dbezverkhnii deleted the feature/COR-181-make-mailcore2-independent-from-aws branch September 1, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants