COR-181 - Make MailCore2 independent from AWS - #104
Merged
dbezverkhnii merged 3 commits intoSep 1, 2026
Conversation
lxbndr
previously approved these changes
Sep 1, 2026
dbezverkhnii
deleted the
feature/COR-181-make-mailcore2-independent-from-aws
branch
September 1, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes how all Windows Spark consumers fetch MailCore C++ binaries; a missing or mismatched release asset breaks Windows builds until someone publishes from a Windows machine with
ghauth.Overview
Replaces the Spark Windows MailCore prebuilt pipeline so artifacts and binary deps no longer use the
spark-prebuilt-binariesS3 bucket orSPARK_PREBUILT_KEY. Prebuilts aremailcore2-windows-<digest>.zipon the permanentwindows-prebuiltGitHub release; openssl/sasl/zlib come frommailcore2-windows-deps-1.zipon the same release.The digest is derived from git tree entries over
src(excludingsrc/swift),CMakeLists.txt, andbuild-windows-5.10, so checkouts pick the right archive without bumping$PrebuiltMailcoreVersioninGet-Mailcore2.ps1.Publish-Mailcore2Prebuilt.ps1builds, stampsetc/mailcore2-source-digest, verifies the package, and uploads viagh.Get-Mailcore2.ps1downloads publicly, treats only HTTP 404 as “missing prebuilt”, and rejects archives whose stamped digest does not match.A new pull-request job (
mailcore2 - Windows prebuilton Ubuntu) runsCheck-PrebuiltPublished.ps1against the merge commit so a forgotten publish fails in the PR (including rebase hints when the branch head already has an archive).README.mdand newAGENTS.mddocument publish and check behavior.Reviewed by Cursor Bugbot for commit e44c2f7. Bugbot is set up for automated code reviews on this repo. Configure here.