COR-170 - Verify TLS certificate hostnames on non-Apple platforms

.arcconfig

@@ -0,0 +1,3 @@
+{
+	"phabricator.uri" : "https://phabricator.readdle.com/"
+}

.github/workflows/pull-request-check.yml

@@ -0,0 +1,113 @@
+name: Pull Request Check
+
+on: pull_request
+
+defaults:
+  run:
+    shell: zsh -l {0} # Use zsh iwth login as default shell
+
+concurrency:
+  group: ${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+
+  Android:
+    name: "mailcore2 - Android"
+    runs-on: macos-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Select Xcode 26.2
+      run: sudo xcode-select -s /Applications/Xcode_26.2.app
+
+    - name: Install Swift 6.2.1 toolchain
+      run: |
+        curl -L -O https://download.swift.org/swift-6.2.1-release/xcode/swift-6.2.1-RELEASE/swift-6.2.1-RELEASE-osx.pkg
+        sudo installer -pkg swift-6.2.1-RELEASE-osx.pkg -target /
+
+    - name: Install Swiftly shim
+      run: |
+        # The Readdle Gradle plugin invokes "swiftly run +6.2 swift build ..."
+        # Swiftly's install script does not support macOS 15 yet, so we create
+        # a shim that delegates to the Swift 6.2.1 toolchain (must match the
+        # SDK's module version exactly).
+        SWIFT_621="/Library/Developer/Toolchains/swift-6.2.1-RELEASE.xctoolchain/usr/bin"
+        mkdir -p ~/.swiftly/bin
+        cat > ~/.swiftly/bin/swiftly << SHIM
+        #!/bin/bash
+        if [ "\$1" = "run" ]; then
+            shift 2
+            exec env PATH="$SWIFT_621:\$PATH" "\$@"
+        fi
+        exec "\$@"
+        SHIM
+        chmod +x ~/.swiftly/bin/swiftly
+        echo "$HOME/.swiftly/bin" >> $GITHUB_PATH
+
+    - name: Install Readdle Swift Android SDK
+      run: |
+        swift sdk install https://github.com/readdle/swift-android-toolchain/releases/download/6.2-r1/readdle-swift-6.2.1-RELEASE_android.artifactbundle.tar.gz \
+          --checksum 2057ecd9cf71fcd9beaded08d370f4815f867983c073f2d0010796aefdf8c2f1
+        ~/Library/org.swift.swiftpm/swift-sdks/readdle-swift-6.2.1-RELEASE_android.artifactbundle/swift-android/scripts/setup-android-sdk.sh
+
+    - name: Install Swift Android Build Tools
+      run: |
+        git clone https://github.com/readdle/swift-android-buildtools.git ~/swift-android-buildtools
+        echo "$HOME/swift-android-buildtools" >> $GITHUB_PATH
+
+    - name: Run connected android tests
+      run: swift-android build --build-tests
+
+  Windows:
+    name: "mailcore2 - Windows prebuilt"
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    permissions:
+      contents: read
+
+    # There is no Windows CI: the C/C++ for Windows is built by hand and published as a release
+    # asset named after a digest of the sources. This job does not build anything - it only asks
+    # whether the archive for these sources exists, so that a forgotten upload is caught in the
+    # pull request instead of in the spark-core build days later. The digest is a hash of git
+    # tree entries, identical on every platform, so a Linux runner answers it in seconds.
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+      with:
+        fetch-depth: 2 # the pull request merge commit and both of its parents
+
+    - name: Check that a prebuilt is published for these sources
+      shell: pwsh
+      env:
+        GH_TOKEN: ${{ github.token }}
+      run: ./build-windows-5.10/Check-PrebuiltPublished.ps1
+
+  Darwin:
+    name: "mailcore2 - ${{ matrix.os }}"
+    runs-on: macos-latest
+    timeout-minutes: 60
+
+    strategy:
+      matrix:
+        os: [macOS, iOS]
+        include:
+          - os: macOS
+            os_lowercased: macos
+          - os: iOS
+            os_lowercased: ios
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+    - name: Run tests
+      run: ./build-scripts/test-${{ matrix.os_lowercased }}.sh
+    - name: Publish Report
+      uses: mikepenz/action-junit-report@v3
+      if: failure()
+      with:
+        report_paths: .build/reports/junit.xml
+        check_name: mailcore2 - ${{ matrix.os }} - Report
+        detailed_summary: true
+        include_passed: true

.gitignore

@@ -23,6 +23,7 @@ DerivedData
 *.hmap
 *.xcuserstate
 *.xccheckout
+build-mac/mailcore2.xcodeproj/project.xcworkspace/xcshareddata
 
 #CocoaPods
 Pods
@@ -33,7 +34,6 @@ Podfile.lock
 *.opensdf
 *.suo
 Externals
-build-mac/mailcore2.xcodeproj/project.xcworkspace/xcshareddata
 build-windows/include
 build-windows/_headers_depends
 build-windows/mailcore2/Debug
@@ -48,4 +48,15 @@ build-windows/mailcore2/test/Release
 build-windows/mailcore2/test/x64/Release
 build-windows/mailcore2/test/Debug
 build-windows/mailcore2/test/x64/Debug
+build-windows/mailcore2/mailcore2/mailcore2.vcxproj.user
 cocoapods-build
+*.aar
+.build
+.vs
+
+LinuxMain.swift
+third-party
+test.log
+junit.xml
+.build-ios
+ndk-stack.log

.sourcery.LinuxMain.stencil

@@ -0,0 +1,15 @@
+import XCTest
+{{ argument.testimports }}
+
+{% for type in types.classes|based:"XCTestCase" %}
+{% if not type.annotations.disableTests %}extension {{ type.name }} {
+  static var allTests = [
+  {% for method in type.methods %}{% if not method.annotations.disableTest and method.parameters.count == 0 and method.shortName|hasPrefix:"test" %}  ("{{ method.shortName }}", {{ method.shortName }}),
+  {% endif %}{% endfor %}]
+}
+
+{% endif %}{% endfor %}
+
+XCTMain([
+{% for type in types.classes|based:"XCTestCase" %}{% if not type.annotations.disableTests %}  testCase({{ type.name }}.allTests),
+{% endif %}{% endfor %}])

.sourcery.yml

@@ -0,0 +1,9 @@
+# This is config file for sourcery, just run `sourcery` in this folder
+sources:
+  - unittest
+templates:
+  - .sourcery.LinuxMain.stencil
+output:
+  LinuxMain.swift
+args:
+  testimports: '@testable import MailCoreTests'

.travis.yml

@@ -4,4 +4,3 @@ os:
 language: c++
 before_script: scripts/travis/before-script.sh
 script: scripts/travis/script.sh
-osx_image: xcode7

AGENTS.md

@@ -0,0 +1,98 @@
+# Working in this repository
+
+This is Readdle's fork of MailCore 2. Most of it is the upstream C++ library; the parts we
+maintain are the C wrapper (`src/c`), the Swift bindings (`src/swift`) and the Windows build
+under `build-windows-5.10`.
+
+## Publishing the Windows prebuilt
+
+Spark's Windows build does not compile the mailcore2 C++ from source. It downloads an archive
+whose name is derived from the content of the C/C++ sources, so **sources that were never built
+simply have no archive** and the Spark build says so:
+
+```
+Prebuilt MailCore not found: mailcore2-windows-<digest>.zip
+Have you built and uploaded it yet?
+```
+
+There is no Windows CI. The `mailcore2 - Windows prebuilt` pull-request check asks the same
+question earlier, on every pull request, and goes red when the answer is no. Either way,
+someone has to build and publish from a Windows machine — that is what "build and upload the
+Windows changes" means.
+
+You can ask the same question yourself, from anywhere, without a Windows machine:
+
+```powershell
+pwsh ./build-windows-5.10/Check-PrebuiltPublished.ps1
+```
+
+### The whole procedure
+
+On a Windows build machine, in a checkout of this repository **at the revision that needs the
+prebuilt** (a branch head, a tag, anything committed):
+
+```powershell
+.\build-windows-5.10\Publish-Mailcore2Prebuilt.ps1
+```
+
+That is the entire job. It computes the digest, exits early if that archive already exists,
+fetches the dependency archive, clears the previous build output, builds through
+`Build-Mailcore2.ps1`, stamps the digest, packages, verifies the package, and adds it to the
+release.
+
+**Do not commit anything to mailcore2 afterwards.** The archive is named after the sources, so
+the revision that needs it will find it. Committing, opening the PR and tagging are the
+developer's job, not the agent's.
+
+### The release
+
+Archives live on the permanent `windows-prebuilt` release, set up by hand once.
+`Publish-Mailcore2Prebuilt.ps1` only adds `mailcore2-windows-<digest>.zip` to it. If it is
+somehow missing, say so rather than creating one.
+
+### Requirements
+
+The same machine that has always built mailcore2 for Windows: the toolchain the build expects
+(Swift for Windows, VS 2022 Build Tools, the Windows SDK) and the internal RD PowerShell
+modules. Nothing about the build changed.
+
+What did change: no AWS credential. `SPARK_PREBUILT_KEY` is gone, and the three binaries it
+used to fetch travel as one public asset on the release. Publishing additionally needs `gh`
+authenticated as a user with write access (`gh auth login`).
+
+The working tree must be committed. The digest describes `HEAD`, so uncommitted changes under
+`src` (excluding `src/swift`), `CMakeLists.txt` or `build-windows-5.10` make the script refuse
+to run.
+
+### When it fails
+
+- *Uncommitted changes under …* — commit them first, or test locally by passing
+  `-BuildMailcore2` to `Build-SwiftMailcore.ps1` instead of publishing.
+- *The windows-prebuilt release does not exist* — ask the developer; see "The release" above.
+- *Could not download the dependency archive* — `mailcore2-windows-deps-<n>.zip` carries
+  openssl, sasl and zlib and is attached to the release by hand. If it is not there, ask the
+  developer to attach it. The message names the path a local copy can be dropped at instead.
+- *GitHub CLI is not authenticated* — `gh auth login`. Do not work around this with a token
+  pasted into the shell.
+- Anything about ICU, libxml2 or the toolchain — that is the build machine's setup, unchanged by
+  this flow. Do not try to install or relocate it.
+
+### What not to do
+
+- Do not edit the archive by hand or upload one built from an uncommitted tree.
+- Do not delete a published `mailcore2-windows-<digest>.zip`: revisions that were built against
+  it keep downloading it by name. Re-uploading the *same* digest after a rebuild is the only
+  legitimate replacement, and `-Force` exists for exactly that.
+- Do not create the release or attach the dependency archive. Both are the developer's.
+- Do not add a version number anywhere. The digest replaced it; there is nothing to bump.
+
+### What the digest covers
+
+`src` (without `src/swift`), `CMakeLists.txt`, and `build-windows-5.10` — the scripts included,
+because they decide what gets compiled, which project files and redistributables get copied in,
+and what ends up in the package. So there is no way to change the contents of an archive without
+changing its name.
+
+The price is the other direction: editing any script here, even a message or the pull-request
+check, produces a new digest and asks for a rebuild. Expect that, and prefer to land script edits
+together with whatever else needs republishing.