COR-173 - Test IMAP idle interruption - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Test-only changes with no production MailCore behavior modified; CI impact is limited to Darwin test runs.
Overview
Adds Darwin-only XCTest coverage for IMAP IDLE teardown, ported from upstream’s
test-imap-idle.cpp“cancel wakes IDLE” scenario (the disconnect race half is omitted because the Swift API lacks the synchronous C++ session).A local
FakeIdleIMAPServer(POSIX listening socket on127.0.0.1) drivesMCOIMAPSessionthrough LOGIN/LIST/SELECT into IDLE and observesDONE/close. Tests run work off the main thread so MailCore’s main-queue operation lifecycle can proceed.testInterruptIdleEndsRunningIdleasserts thatinterruptIdle()ends a running IDLE and the server seesDONE.testCancelAllOperationsWakesRunningIdleasserts thatcancelAllOperations()should wake a blocked IDLE; it is wrapped inXCTExpectFailureuntil upstream merges the fix whereIMAPIdleOperation::cancel()callsinterruptIdle(), with cleanup viainterruptIdle()when the expectation is not met.Package.swiftregistersIMAPIdleCancellationTests.swiftin the MailCoreTests target.Reviewed by Cursor Bugbot for commit 2f5ba01. Bugbot is set up for automated code reviews on this repo. Configure here.