Upgrades; fix for current RS ana handling - #5
Conversation
|
Ah - I remember. Yes, we decided to change the serialization format.
My sense: yes :-) So this should definitely be fied in the standoff-converter crosswalk, since we're now clearly out of sync. At the same time, I wonder if it makes sense to also keep the shim - at least temporary - as a precaution? Do people still have documents around in the old format? The hoisting as such doesn't break anything and could safely stay in there for a while. If we keep it, we should probably make a note in the code, e.g. just pointing to this discussion here? |
rsimon
left a comment
There was a problem hiding this comment.
Hi @blms,
just a note to say I made two additions:
- Upgraded the
standoff-converterpackage dependency to the latest version I just published to the npm registry - Upgraded the
uuidpackage to the latest version. (The old version caused security warnings; and the new version is compatible - tested in several of my projects.)
|
Looks great, thank you! |
In this PR
NER annotations began appearing like this in the current RS frontend:
This is because of this change: recogito/recogito-client@55491cff
This PR:
Questions
Does it make sense to shim the plugin like this, or would it be better to make a modification directly in
@recogito/standoff-converter?