Skip to content

feat(rhdh chart): Add option to specify RHDH route's targetPort - #520

Merged
openshift-merge-bot[bot] merged 4 commits into
redhat-developer:mainfrom
pmacik:feat/rhdh-route-targetPort
Sep 4, 2026
Merged

feat(rhdh chart): Add option to specify RHDH route's targetPort#520
openshift-merge-bot[bot] merged 4 commits into
redhat-developer:mainfrom
pmacik:feat/rhdh-route-targetPort

Conversation

@pmacik

@pmacik pmacik commented Sep 3, 2026

Copy link
Copy Markdown

Description of the change

In the legacy backstage chart, there was a way to change the target port of the RHDH route on OpenShift. That was useful in case of the oauth2-proxy auth provider introduced as extra container.

In the new standalone rhdh chart, the target port is hard-coded to be http-backend

This PR introduces a chart value opehshift.route.targetPort (with a default value of http-backend) that allows changing route's the target port.

Which issue(s) does this PR fix or relate to

  • JIRA_issue_link

How to test changes / Special notes to the reviewer

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Run pre-commit run --all-files to run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

@pmacik pmacik changed the title feat(rhdh): Add option to specify RHDH route's targetPort feat(rhdh chart): Add option to specify RHDH route's targetPort Sep 3, 2026

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's update the schema now to fix the CI failures. Thanks.

Comment thread charts/rhdh/templates/route.yaml
@pmacik
pmacik marked this pull request as ready for review September 3, 2026 16:54
@pmacik
pmacik requested a review from a team as a code owner September 3, 2026 16:54
@pmacik
pmacik requested a review from rm3l September 3, 2026 16:55
@pmacik
pmacik force-pushed the feat/rhdh-route-targetPort branch from 2c24e53 to d03a578 Compare September 3, 2026 21:42
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik
pmacik force-pushed the feat/rhdh-route-targetPort branch from d03a578 to cff98b0 Compare September 4, 2026 08:31
@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2026

Copy link
Copy Markdown

@openshift-ci openshift-ci Bot added the lgtm label Sep 4, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 09a0f34 into redhat-developer:main Sep 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants