feat(prepare-sources): scaffold pipeline CLI and GitHub Action - #154
Merged
davidfestal merged 17 commits intoAug 25, 2026
Merged
Conversation
…b Action Add the initial `prepare-rhdh-supported-sources` Node.js package with a pluggable pipeline runner, CLI argument parsing, a composite GitHub Action, and a CI workflow. Includes shared types, fixture-based test utilities, a template module, and placeholder pipeline modules for the RHDH supported sources flow. Signed-off-by: David Festal <dfestal@redhat.com>
…mat test utilities Signed-off-by: David Festal <dfestal@redhat.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…r dependency install Signed-off-by: David Festal <dfestal@redhat.com>
…ilities. Signed-off-by: David Festal <dfestal@redhat.com>
The rhdh prefix is redundant since the repo is already RHDH-scoped, and "supported" is implied by context. Renamed the package directory, CI workflow references, GitHub Action metadata, and CLI usage string. Signed-off-by: Jon Koops <jonkoops@gmail.com>
Bump to Node 24, @types/node 24, vite-plus 0.2.9, and add explicit typescript 7. Replace .node-version with devEngines. Use setup-vp in CI instead of setup-node + npm ci, pin actions to commit hashes, and rename the workflow. Trim tsconfig to TS7 defaults and add stricter checks (noUncheckedIndexedAccess, noImplicitReturns, noFallthroughCasesInSwitch). Configure type-aware linting in vite.config. Signed-off-by: Jon Koops <jonkoops@gmail.com>
jonkoops
changed the title
Assisted-by: Cursor Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
add-downstream-prepare-source-cli
branch
from
August 20, 2026 16:11
6fa4274 to
9cd9a2a
Compare
jonkoops
reviewed
Aug 20, 2026
Assisted-by: Cursor Signed-off-by: David Festal <dfestal@redhat.com>
Remove the structured logging and minimal dependencies sections, move pipeline modules up below usage, add the --help flag, and fix inaccurate descriptions. Signed-off-by: Jon Koops <jonkoops@gmail.com>
Merge parseArgs into cli.ts since it has no other consumers. Refactor CliArgs to a discriminated union for type-safe command dispatch, fix --help to print to stdout and exit 0, report missing required flags individually, and rewrite the usage text to follow GNU conventions. Signed-off-by: Jon Koops <jonkoops@gmail.com>
polasudo
reviewed
Aug 24, 2026
…dirs Replace module-level tempDirs arrays and afterEach hooks with the Disposable protocol. ModuleFixture and TempDir implement Symbol.dispose, so callers use `using` declarations for automatic cleanup tied to scope rather than shared mutable state. Consolidate the duplicated tempDir helpers into a single exported makeTempDir in test-utils. Signed-off-by: Jon Koops <jonkoops@gmail.com>
Replace switch with if/else if, remove the try/catch wrapper, and drop explicit exit codes. Errors now propagate naturally with full stack traces and Node.js sets the exit status automatically. Ref: https://redhat.atlassian.net/browse/RHIDP-1234 Signed-off-by: Jon Koops <jonkoops@gmail.com>
… module Move SourceJson type, field validation, file reading, and parsing logic from pipeline.ts into source.ts. The new readSourceFile() function provides validated, cast-free parsing with chained error causes. Error messages now consistently quote file paths and use a unified prefix. Signed-off-by: Jon Koops <jonkoops@gmail.com>
Extract each variant of the CliArgs discriminated union into a named interface (HelpArgs, ListModulesArgs, RunArgs) for readability. Signed-off-by: Jon Koops <jonkoops@gmail.com>
… pipeline.ts Co-locate the pipeline types with the code that creates and consumes them, eliminating the types.ts barrel file. Signed-off-by: Jon Koops <jonkoops@gmail.com>
Enable the oxlint suspicious category as errors and fix the three violations: inline a test helper to satisfy consistent-function-scoping, replace sort() with toSorted() to avoid array mutation. Signed-off-by: Jon Koops <jonkoops@gmail.com>
Wrap module failures with Error cause instead of log-and-rethrow, and switch progress logging from console.error to console.info. Signed-off-by: Jon Koops <jonkoops@gmail.com>
|
jonkoops
approved these changes
Aug 25, 2026
polasudo
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
prepare-sourcesNode.js package with a pluggable pipeline runner, CLI argument parsing, a composite GitHub Action, and a CI workflow. Includes shared types, fixture-based test utilities, a template module, and placeholder pipeline modules for the RHDH supported sources flow.Fixes RHIDP-15831