Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions redisbench_admin/run/args.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,17 @@ def common_run_args(parser):
default=ARCH,
help=f"Architecture to run the benchmark on. One of {VALID_ARCHS}.",
)
parser.add_argument(
"--running_platform",
type=str,
required=False,
default=None,
help="Platform identifier recorded in the time-series key and labels, "
"for example the instance class the benchmark ran on. Without it, runs "
"on different hardware share a single series, because labels are "
"per-series rather than per-sample and get overwritten by the latest "
"push. Set it to keep results from different platforms separable.",
)
parser.add_argument(
"--keep_env_and_topo",
required=False,
Expand Down
1 change: 1 addition & 0 deletions redisbench_admin/run_local/run_local.py
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ def run_local_command_logic(args, project_name, project_version):
github_repo_name,
tf_triggering_env,
metadata_tags,
running_platform=args.running_platform,
tf_github_sha=push_github_sha,
arch=push_arch,
)
Expand Down
1 change: 1 addition & 0 deletions redisbench_admin/run_remote/run_remote.py
Original file line number Diff line number Diff line change
Expand Up @@ -1479,6 +1479,7 @@ def run_remote_command_logic(args, project_name, project_version):
tf_github_repo,
tf_triggering_env,
metadata_tags,
running_platform=args.running_platform,
tf_github_sha=push_github_sha,
arch=push_arch,
)
Expand Down
Loading