Mark ts-info as not obsolete - #553
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #548
As best as I can tell from history, this seems to have been fallout from marking
MaxSamplesPerChunkobsoleteNote
Low Risk
Attribute-only API hygiene; no command, parsing, or runtime behavior changes besides compiler warnings.
Overview
Stops treating
TS.INFOas obsolete.Info/InfoAsync,ToTimeSeriesInfo, and theTimeSeriesInformationconstructor are no longer[Obsolete]; onlyMaxSamplesPerChunkremains deprecated.The constructor still fills
MaxSamplesPerChunkfor older RedisTimeSeries, with a local warning suppression. Tests drop the extra[Obsolete]attributes that were only needed because of those APIs.Reviewed by Cursor Bugbot for commit e86e168. Bugbot is set up for automated code reviews on this repo. Configure here.