feat(mcp): enforce least-privilege read-only tool access - #29
Open
OllieinCanada wants to merge 1 commit into
Open
feat(mcp): enforce least-privilege read-only tool access#29OllieinCanada wants to merge 1 commit into
OllieinCanada wants to merge 1 commit into
Conversation
|
1 similar comment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/listfiltering forX-MCP-Readonly: truefalseHTTP requests and stdio full-access, while preventing read-only workspace listing from changing compatibility session stateREAD ONLYtransaction retained as a backstopThe tool annotation audit is the single policy source for both listing and invocation. Registration tests assert the exact named read-only and mutating sets, and unknown tools fail closed.
falsetrueValidation
go build -v ./...go testgo vet ./...--new-from-rev upstream/main:0 issues.go generate ./...completed; its unrelated pre-existing fake-output drift was excluded from this PRgit diff --checkgo.mod,go.sum, or generated-fake changesThe Windows host has no cgo C compiler, so Go's local
-racemode could not start. The repository's Linux CI runs the exact required race-enabled non-e2e suite.Fixes #5