feat(pos-app): add sandbox mode and CI flag - #597
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Claude finished @ignaciosantise's task in 3m 38s —— View job Code Review
Found 3 issue(s)Issue 1: Success/decline condition ($0.01 magic value) not surfaced to testersID: scan-sandbox-magic-amount-3f9a Context:
Recommendation: Document the rule in the sandbox banner or instruction text. Minimal change — update // sandbox-banner.tsx or scan.tsx instruction text
"Sandbox mode · Enter $0.01 to approve, any other amount to decline"Alternatively, make the threshold a named constant and document it in a comment. Issue 2: "Copy payment link" copies a non-functional sandbox URLID: scan-sandbox-copy-url-a2c1 Context:
Recommendation: Disable the copy handler in sandbox mode or suppress the toast: const handleCopyPaymentUrl = async () => {
if (isSandboxPayment) return; // no real URL to copy
await Clipboard.setStringAsync(qrUri);
showSuccessToast("Payment link copied");
};Issue 3: Missing accessibility label on SandboxBannerID: sandbox-banner-a11y-7d3e Context:
Recommendation: <View
accessibilityRole="alert"
accessibilityLabel="Sandbox mode active. Payments are simulated."
style={[styles.container, { backgroundColor: theme["bg-warning"] }, style]}
>Breaking changes: ✅ None — store migration (v19→v20) initialises Data classification: ✅ None — no real credentials or PII in sandbox data; secrets remain in |
…mode # Conflicts: # dapps/pos-app/app/amount.tsx # dapps/pos-app/app/scan.tsx
Summary
$0.01success and$0.02decline, with local transaction samples and sandbox banners.sandbox-enabledcheckbox to the Mobile POS release workflow and inject it into Android/iOS Expo builds.Validation
git diff --checkpassed.node_modulesis not installed in the workspace.