Support connector-scoped OpenAI-compatible request behavior - #9826
Open
dfliess wants to merge 2 commits into
Open
Support connector-scoped OpenAI-compatible request behavior#9826dfliess wants to merge 2 commits into
dfliess wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
structured_output_modewith the existingjson_schemabehavior as the default and ajson_objectfallback that includes the schema in the promptextra_bodymap for provider-specific chat completion fields while rejecting overrides of core request and response-shape fieldsMotivation
OpenAI-compatible providers differ in structured-output support and provider-specific request extensions. This was motivated by an interoperability report in kairosagentica/kairos-cloud#145.
The defaults remain unchanged for existing OpenAI connectors, and all new behavior is configured per connector.
Test plan
go test -race ./runtime/drivers/openai -run "TestComplete(AppliesConnectorRequestBehavior|PassesNestedExtraBody|DefaultsToJSONSchema)|TestOpenValidatesProviderRequestBehavior" -count=1go test ./runtime -run TestGenerateConnectionKey -count=1go test ./runtime/... -run "^$"go vet ./runtime/drivers/openai ./runtimegit diff --check upstream/main...HEAD