fix(search): enforce pagination bounds on search list endpoints - #1354
Open
DevALVIN-24 wants to merge 1 commit into
Open
fix(search): enforce pagination bounds on search list endpoints#1354DevALVIN-24 wants to merge 1 commit into
DevALVIN-24 wants to merge 1 commit into
Conversation
|
@DevALVIN-24 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Well done on the job done so far! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1309
Overview
This PR enforces validation and bounding for pagination parameters in the
searchendpoint, preventing clients from requesting an unbounded number of rows (which poses a memory, DoS, and performance risk).Changes Made
PaginationDto: Added a new DTO insrc/search/dto/pagination.dto.tsusingclass-validatorto enforce pagination constraints and type conversion.page: Minimum is 1. Default is 1.limit: Minimum is 1. Maximum is clamped at 100. Default is 20.400 Bad Requestthrough NestJS'sValidationPipecombined with@IsInt(),@Min(),@Max(), and@Type(() => Number).src/search/search.controller.tswith the new validatedPaginationDto.@ApiQueryto properly reflect and document the maximum page size (100) alongside default limits.Testing/Acceptance Criteria Verified
limit=200) is rejected with a400 Bad Request.400 Bad Request.limitorpagesucceed by automatically applying the1(page) and20(limit) defaults.