Feat/1222 add experiment metric indexes - #1367
Open
Peolite001 wants to merge 3 commits into
Open
Conversation
- Add @Index decorators for experimentId FK, type, createdAt, and composite (experimentId, isPrimary) to ExperimentMetric entity - Add migration 1801000000000 to create the same indexes on existing databases with a clean down() rollback
|
@Peolite001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Well done on the job done so far! |
Author
done |
Contributor
|
Your workflow is still failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1222
Adds database indexes to the
experiment_metricstable to prevent sequential scans as the table grows. Both entity-level@Indexdecorators and a corresponding migration are included so existing databases are updated via a reviewable migration.Changes
src/ab-testing/entities/experiment-metric.entity.tsIndexfromtypeorm@Indexdecorators to the entity class:IDX_experiment_metrics_experiment_idexperimentIdexperiment.metricsrelationIDX_experiment_metrics_typetypeIDX_experiment_metrics_created_atcreatedAtORDER BY createdAt DESCin list queriesIDX_experiment_metrics_experiment_is_primaryexperimentId, isPrimarysrc/migrations/1801000000000-add-experiment-metric-indexes.ts(new)queryRunner.createIndicesdown()drops them in reverse order for clean rollbackChecklist
down()migration cleanly rolls back all indexes