perf(ab-testing): add indexes to experiment entity + migration - #1371
Open
wright2341 wants to merge 3 commits into
Open
perf(ab-testing): add indexes to experiment entity + migration#1371wright2341 wants to merge 3 commits into
wright2341 wants to merge 3 commits into
Conversation
|
@wright2341 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Well done on the job done so far! |
Author
|
Hi @RUKAYAT-CODER — I've fixed the workflow. The experiment entity now has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds database indexes to the
experimententity so common lookup, filter, sort, and foreign-key query paths no longer trigger sequential scans as the table grows. Indexes are declared via@Indexon the entity and created by a reviewable migration so existing databases are updated without relying onsynchronize.Related Issue
Changes
🗂️ Experiment Entity Indexing
[MODIFY]
src/ab-testing/entities/experiment.entity.ts@Indexdecorators covering the columns used in WHERE / ORDER BY / JOIN / foreign-key lookups.[ADD]
src/migrations/1756475492000-add-experiment-indexes.tsup()creates the same indexes declared on the entity so existing databases are brought in line.down()drops them, keeping the migration reversible.Verification Results
@Indexdecorators added to entitymigration:runon a populated DBCloses #1224