feat: add indexes and migration to ab-test entity - #1378
Open
339mon wants to merge 2 commits into
Open
Conversation
|
@339mon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Well done on the job done so far! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds database indexes to the
ab-testentity so the common query paths (lookups, filtering, sorting, and foreign-key joins) stay performant as the table grows. Indexes are declared on the entity via@Indexdecorators and are also created by a reviewable migration so existing databases are updated without relying onsynchronize.Related Issue
Closes: Add database indexes to the ab-test entity
Changes
🗂️ AB-Test Entity Indexing
[MODIFY]
src/email-marketing/entities/ab-test.entity.tsab-testand identified the columns used in WHERE / ORDER BY / JOIN / foreign-key lookups.@Indexdecorators (single-column and composite as appropriate) covering the frequently-queried columns and foreign keys.[ADD]
src/migrations/1756476695000-add-ab-test-indexes.tsup()creates each index;down()drops them, keeping the migration cleanly reversible.Verification Results
@Indexdecorators added for WHERE/ORDER BY/JOIN/FK columnsCloses #1231