#1244 Add database indexes to consumer-privacy-preference entity - #1407
Open
Emelie-Dev wants to merge 1 commit into
Open
#1244 Add database indexes to consumer-privacy-preference entity#1407Emelie-Dev wants to merge 1 commit into
Emelie-Dev wants to merge 1 commit into
Conversation
…tity - Create ConsumerPrivacyPreference entity with @Index decorators - Add indexes for userId, tenantId, tenantId+userId composite, doNotSellMyPersonalInformation flag, and lastCcpRequestDate - Add migration to create table and indexes with IF NOT EXISTS safety
|
@Emelie-Dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Well done on the job done so far! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add database indexes to the
consumer-privacy-preferenceentity based on its common lookup, filtering, sorting, and foreign-key query paths.What changed
consumer-privacy-preference.@Indexdecorators to the entity for frequently queried and foreign-key columns.Indexing Strategy
The indexes target columns used for:
WHERElookups.Composite indexes are used where multiple columns are queried together, rather than introducing overlapping single-column indexes unnecessarily.
Migration
The migration:
synchronize.Acceptance Criteria
@Indexdefinitions.Validation
The relevant TypeScript build, lint, and test/migration validation commands were run as applicable.
The migration was also reviewed to ensure its
updefinitions match the entity indexes and itsdownoperation cleanly removes them.Files Changed
src/modules/ccpa/entities/consumer-privacy-preference.entity.tssrc/migrations/-add-consumer-privacy-preference-indexes.tsCloses #1244