fix(caching): bound and prioritise cache warming repository reads - #1409
Merged
Conversation
|
@chainsmt Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounds all cache-warming repository reads and prevents startup warming from delaying readiness.
takesized from a configurableCACHE_WARM_MAX_ENTRIES(ConfigService/env, default 100); replaces the unbounded published-courses find that loaded the whole table into memory.createdAttie-breaker), users by most-recent activity (lastLoginAt DESC).CACHE_WARM_BATCH_SIZE, default 25) with a short delay between batches (CACHE_WARM_BATCH_DELAY_MS, default 50ms) to bound DB/memory pressure.cache_warm_entries_total,cache_warm_last_entries, andcache_warm_duration_seconds.OnModuleInittoOnApplicationBootstrapdispatched viasetImmediate(not awaited), so warming runs after the server is accepting traffic and never delays readiness.Testing
npx tsc --noEmit— cleannpm run lint— cleannpx jest src/caching/cache-warming— 2 suites, 10 tests pass (bounding cap, enrollment ordering, batching/delay, metrics, deferred non-blocking bootstrap). Pre-existing unrelated caching spec failures are unchanged.Closes #1053