feat: add deterministic percentage rollout to feature flags - #1312
Open
Marvy54 wants to merge 2 commits into
Open
feat: add deterministic percentage rollout to feature flags#1312Marvy54 wants to merge 2 commits into
Marvy54 wants to merge 2 commits into
Conversation
Contributor
|
Well done on the job done so far! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds deterministic percentage rollout to feature flags. Flags can now be evaluated against a stable, hash-based bucket so a rollout percentage between 0 and 100 can be applied consistently across repeated evaluations. Existing boolean flags remain fully supported by treating them as 0% / 100% rollouts.
Related Issue
Closes #
Changes
🚩 Percentage Rollout Engine
[ADD]
src/lib/feature-flags/index.tsevaluateFlag(flag, context)with deterministic hash-based bucketing.rolloutPercentagein flag definitions, with0= always off and100= always on.[MODIFY]
src/lib/feature-flags/store.tsrolloutPercentageto the stored flag schema.updateRollout/setRolloutPercentageactions and persists rollout changes alongside the existing enabled state.rolloutPercentageto100, preserving current boolean behavior.[ADD]
src/lib/feature-flags/__tests__/feature-flags.test.tsVerification Results
index.tsandstore.tsCloses #1187