fix(guard): allow path-based WebSocket requests without sec-websocket-protocol header - #5664
Open
Tyagiquamar wants to merge 1 commit into
Open
Conversation
…-protocol header In path-based WebSocket routing (read_gateway_token_for_path_based), if sec-websocket-protocol header is absent, return Ok(None) instead of failing with MissingHeader error. This allows path-based WebSocket connections (e.g. Hub UI inspector console) to connect without requiring a token header. Signed-off-by: Tyagiquamar <mohdquamartyagi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In path-based WebSocket routing (
ead_gateway_token_for_path_based), if \sec-websocket-protocol\ header is absent, return \Ok(None)\ instead of failing with a \MissingHeader\ error.
This allows path-based WebSocket connections (such as the Hub UI inspector console) to connect without requiring a token header when unauthenticated or when the token is omitted.
Fixes #5481.