Skip to content

Fix Rumble issue inbox account extraction #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flemming-n-larsen merged 1 commit into from
Aug 31, 2026
Merged

Fix Rumble issue inbox account extraction #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ingest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ jobs:
GH_TOKEN: ${{ github.token }}
run: |
mkdir -p .inbox
gh api --paginate "repos/$GITHUB_REPOSITORY/issues?labels=result-submission&state=open&per_page=100" --jq '.[] | select(.pull_request == null) | {number,author,body} | @base64' > .inbox/issues
gh api --paginate "repos/$GITHUB_REPOSITORY/issues?labels=result-submission&state=open&per_page=100" --jq '.[] | select(.pull_request == null) | {number,user,body} | @base64' > .inbox/issues
while read -r encoded; do
[ -z "$encoded" ] && continue
printf '%s' "$encoded" | base64 --decode > .inbox/issue.json
number=$(jq -r .number .inbox/issue.json)
account=$(jq -r .author.login .inbox/issue.json)
account=$(jq -r .user.login .inbox/issue.json)
jq -r .body .inbox/issue.json > .inbox/body.md
: > .inbox/outcome.txt
if python scripts/extract_envelope.py --body .inbox/body.md --output .inbox/envelope.json >> .inbox/outcome.txt 2>&1 && python scripts/ingest.py --root . --account "$account" --input .inbox/envelope.json >> .inbox/outcome.txt 2>&1; then
Expand Down
7 changes: 7 additions & 0 deletions tests/test_rumble_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,13 @@ def testRDA001_IntegrationPositive_valid_batch_becomes_immutable_fact_and_projec
needed = json.loads((self.root / "matchmaking/matches_needed-1v1.json").read_text(encoding="utf-8"))
self.assertIn(["Alpha 1.0", "Charlie 1.0"], [pair["bots"] for pair in needed["priorityPairs"]])

def testRDA001_IntegrationPositive_issue_inbox_uses_GitHub_submitter_account(self) -> None:
workflow = (ROOT / ".github" / "workflows" / "ingest.yml").read_text(encoding="utf-8")

self.assertIn("{number,user,body}", workflow)
self.assertIn("account=$(jq -r .user.login .inbox/issue.json)", workflow)
self.assertNotIn(".author.login", workflow)

def testUnitPositive_engine_pin_accepts_optional_immutable_client_image(self) -> None:
configured = json.loads((self.root / "engine.json").read_text(encoding="utf-8"))
configured["clientImage"] = "ghcr.io/robocode-dev/rumble-client@sha256:" + "a" * 64
Expand Down
Loading