Skip to content

Fix incident severity null deserialization - #19

Merged
kwent merged 2 commits into
masterfrom
features/fix-nullable-incident-severity
Aug 31, 2026
Merged

Fix incident severity null deserialization#19
kwent merged 2 commits into
masterfrom
features/fix-nullable-incident-severity

Conversation

@kwent

@kwent kwent commented Aug 31, 2026

Copy link
Copy Markdown
Member

Summary

  • allow Incident.severity to deserialize and serialize explicit JSON null values
  • add an end-to-end regression test through IncidentResponse.from_dict()
  • run the regression suite across the existing Python version matrix
  • document the fix in the changelog

The corrected OpenAPI schema is deployed, but a full regeneration with openapi-python-client 0.26.2 currently drops the severity endpoints after detecting duplicate response shapes. This focused generated-model patch fixes the production failure without removing those APIs or including unrelated generated changes.

Verification

  • make test
  • uvx --from ruff==0.16.3 ruff check .
  • uvx --from ruff==0.16.3 ruff format --check .

Fixes #18

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 31, 2026
@kwent kwent added bug Something isn't working and removed documentation Improvements or additions to documentation labels Aug 31, 2026
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 31, 2026
@kwent
kwent merged commit 853e718 into master Aug 31, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incident.severity deserialization crashes on the API's own null response

1 participant