Skip to content

Fix sequential and non-interactive terminal resize replay - #138

Open
r-sandeep wants to merge 3 commits into
rootvc:mainfrom
r-sandeep:asd/fix-sequential-resize-replay
Open

Fix sequential and non-interactive terminal resize replay#138
r-sandeep wants to merge 3 commits into
rootvc:mainfrom
r-sandeep:asd/fix-sequential-resize-replay

Conversation

@r-sandeep

Copy link
Copy Markdown
Contributor

Summary

Fix terminal transcript restoration after resize so replay is sequential, non-interactive, and busy-owned for its full duration.

Changes

  • await deep-link replay before replaying command history
  • await each replayed command before rendering the next history entry or final prompt
  • keep term.busy true throughout replay and restore replay state in cleanup
  • coalesce concurrent resize replays behind one promise
  • render apply and animated upgrade history lines without re-running their side effects
  • preserve existing replay behavior for history, analytics, and guarded window opening
  • add focused regression coverage for deep-link ordering, asynchronous command ordering, interactive-flow suppression, busy cleanup, concurrent resize handling, and preserved open behavior

Scope

Only the requested files are changed:

  • js/terminal-ext.js
  • tests/terminal-ext.test.js

No dependencies were added.

Validation

  • npm test — passed: 7 test files, 128 tests
  • npm run build — passed

Both canonical commands also passed in clean-checkout validation on the reviewed repository state.

Approvals and review

  • Required approvals: 15 decided, 0 open
  • Policy decisions: allow; no additional approvals required
  • Final critic review: passed with no unresolved risks or delivery blockers

ASD references

  • Workflow run: workflow_run_42e4928e9c524260a2312e43d97a5a3a
  • Task: task_e8fcae1a7570437ab079659ada789b9c
  • Work packet node: prepare_outcome_delivery
  • Lane: enterprise_bug_fix_council_v1

ASD Agent added 3 commits August 24, 2026 01:22
… in js/terminal-ext.js with focused regressions in tests/terminal-ext.test.js; replay now awaits deep links and
…terminal-ext.js and added focused regressions in tests/terminal-ext.test.js so replay now awaits deep links and
…rminal-ext.js and added focused regressions in tests/terminal-ext.test.js, including the missing deferred async
@r-sandeep
r-sandeep marked this pull request as ready for review August 26, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant