Skip to content

Fix Ctrl+C interruption for running terminal commands - #139

Open
r-sandeep wants to merge 4 commits into
rootvc:mainfrom
r-sandeep:asd/bugfix/ctrl-c-command-interruption
Open

Fix Ctrl+C interruption for running terminal commands#139
r-sandeep wants to merge 4 commits into
rootvc:mainfrom
r-sandeep:asd/bugfix/ctrl-c-command-interruption

Conversation

@r-sandeep

Copy link
Copy Markdown
Contributor

Summary

  • route Ctrl+C to the active command while preserving idle and collectInput behavior
  • cancel timer-backed output primitives through execution-scoped abort state
  • centralize ^C, prompt, busy, and locked cleanup in executeCommandLine
  • isolate resize transcript replay from pending and replay-time interrupts
  • suppress duplicate interrupts and allow the next command to run normally
  • add focused regressions for interruption boundaries, retained mutations, lock cleanup, input collection, replay fencing, and command recovery

Scope

The repair is limited to:

  • js/terminal.js
  • js/terminal-ext.js
  • tests/terminal.test.js
  • tests/terminal-ext.test.js

No command definitions, dependencies, bootstrap code, scripts, or generated assets were changed.

Validation

  • npm run build — passed
  • npm test — passed, 133 tests across 7 test files
  • canonical clean-checkout validation — passed
  • final council review — passed with all four changed paths inspected and no unresolved risks

Approvals

All 54 recorded approvals are decided, no approvals remain open, and all applicable deterministic policy decisions allow delivery.

ASD references

  • Workflow run: workflow_run_e46ac9fc473c4cb0b8ae862b91806df5
  • Task: task_89fc08c42e0e4b44a87e568943b5040f
  • Work packet: prepare_outcome_delivery for enterprise_bug_fix_council_v1

ASD Agent added 4 commits August 24, 2026 12:29
…ent the change: continuation slice ended with durable progress
…and focused regression coverage in the permitted terminal sources and tests; canonical tests and build both pas
…C interruption with isolated resize replay ownership, and explicitly resolved the overlapping replay blocker.
…ent the change: continuation slice ended with durable progress
@r-sandeep
r-sandeep marked this pull request as ready for review August 26, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant