Rework exception macro expansion for faults - #223
Draft
tropicaaal wants to merge 2 commits into
Draft
Conversation
Contributor
|
This is a tricky one. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #221. This also prevents marking
#[entry]s asasync, since that's a no-op (I guess that's technically a breaking change, so I can revert that if needed).example:
This is a draft because there are still some other potential edge cases and things i'm not sure of, notably:
Exception::SupervisorCallhas always done that). If it's the latter only, ischeck_attr_whiteliststill necessary?#[entry]does for clearer user errors, e.g. if the user tried to mark their IRQ handler asasyncor something?addrin the macro? This should now fail after expansion because the macro will attempt to pass the inner function ausize, but we could catch it earlier if we wanted.