Fix case-insensitive matching of literal path components - #191
Open
RanaPriyansh wants to merge 2 commits into
Open
RanaPriyansh wants to merge 2 commits into
RanaPriyansh wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61.
Case-insensitive literal patterns can omit matching files or directories because literal components bypass the pattern matcher.
Enumerate directory entries for these components and use the existing matcher. Preserve direct lookup for case-sensitive, empty,
.and..components. On Windows, use native literal lookup when no directory-entry name matches, preserving paths that use native aliases. Tests cover case variants, intermediate directories, literal hidden files, repeated separators, root paths, and broken symlinks.Local macOS arm64 checks passed with Rust 1.97.1: focused regressions on default and case-sensitive filesystems, the existing integration test, 16 unit tests, repository Clippy, and formatting. The full local suite remains incomplete because its host-wide traversal test was terminated. The unit results exclude that test.
The first submitted revision failed the Windows regression under a temporary path containing a short alias. This update adds native literal continuation. Windows verification remains pending for the updated revision; macOS checks do not execute that Windows-only branch.
OpenAI Codex assisted with implementation, tests, review, and this description.