sanitizers: Implement support for the sanitize ignorelist by 1c3t3a · Pull Request #157808 · rust-lang/rust

1c3t3a · 2026-06-12T11:52:21Z

The sanitize ignorelist gives central controls over which functions, files, etc. should be ignored and not sanitized. It is a common file format for clang and explained here:
https://clang.llvm.org/docs/SanitizerSpecialCaseList.html. This change adds support for this list in Rust as well.

r? @rcvalle

rustbot · 2026-06-12T11:52:24Z

Some changes occurred in tests/codegen-llvm/sanitizer

cc @rcvalle

rustbot · 2026-08-27T10:12:55Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in compiler/rustc_sanitizers

cc @rcvalle

The sanitize ignorelist gives central controls over which functions, files, etc. should be ignored and not sanitized. It is a common file format for clang and explained here: https://clang.llvm.org/docs/SanitizerSpecialCaseList.html. This change adds support for this list in Rust as well.

- Add support for the `[all]` section across all sanitizers. - Restrict CFI ignorelist matching to `[cfi]` and `[cfi-icall]`, ignoring unrelated C++ sub-kinds like `[cfi-vcall]`. - Clean up unused `in_sanitizer_blame` helper. - Add test coverage for `[all]` and `[cfi-icall]`.

In Clang, falling back to [address] for kernel-address (and [hwaddress] for kernel-hwaddress) only applies to global variables, not functions. Update function ignorelist filtering to match Clang.

rustbot · 2026-08-31T16:17:06Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

…d drop safestack

dingxiangfei2009 · 2026-08-31T19:12:59Z

+    /// Opaque type that allows C++ code to write bytes to a Rust-side buffer,
+    /// in conjunction with `RawRustStringOstream`. Use this as `&RustString`
+    /// (Rust) and `RustStringRef` (C++) in FFI signatures.
+    pub(crate) type RustString;


Is this actually rustc_llvm::RustString?

I have a remedy, how about abstracting away the interfaces here into a trait and let rustc_llvm provide a trait implementor? A BuilderMethods extension trait might help.

View changes since the review

Makes sense to me! The only problem I see is that cg_llvm is a standalone crate and has no dependencies on other rustc_* crates. Should this then best extend Builder/CodegenCx in cg_ssa?

dingxiangfei2009 · 2026-08-31T19:20:19Z

+}
+
+impl SanitizerIgnoreList {
+    pub fn new(paths: &[String]) -> Result<Self, String> {


Yeah, some FFI mechanics could be folded into cg_llvm or so.

View changes since the review

Well, we could move the whole SanitizerIgnoreList there, but Ramon mentioned this could also be tucked away in this crate (which arguably encapsulates it nicer). This is the previous discussion, would be curious what you'd advise!

@rcvalle: I discussed offline with Xiang, the trait approach here doesn't really make sense, because both the callsite and the impl of the trait would be in cg_llvm. I still like to have this code here, and my understanding is that the rustc_sanitizers crate is anyways llvm centric? Would it makes sense to put this here like this and eventually rename the crate to rustc_llvm_sanitizers? To make sure the tight coupling to cg_llvm? Would be very curious of your opinion :)

rustbot assigned rcvalle Jun 12, 2026

This comment has been minimized.

Sign in to view

1c3t3a force-pushed the sanitizer-ignorelist branch 2 times, most recently from 624834b to 693e22f Compare June 12, 2026 12:49

1c3t3a requested a review from rcvalle June 12, 2026 14:20

rcvalle reviewed Jun 12, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_llvm/src/builder.rs Outdated

rcvalle reviewed Jun 12, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_llvm/src/builder.rs Outdated

rcvalle reviewed Jun 12, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_llvm/src/builder.rs Outdated

rcvalle requested changes Jun 12, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2026

1c3t3a requested a review from rcvalle June 15, 2026 08:54

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 15, 2026

This comment has been minimized.

Sign in to view

rcvalle requested changes Jul 28, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_llvm/src/common.rs Outdated

Comment thread tests/codegen-llvm/sanitizer/ignorelist/cfi-ignorelist.rs

Comment thread compiler/rustc_codegen_llvm/src/llvm/mod.rs Outdated

Comment thread compiler/rustc_codegen_llvm/src/attributes.rs

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2026

1c3t3a force-pushed the sanitizer-ignorelist branch from a24ff27 to eeed708 Compare August 27, 2026 10:12

This comment has been minimized.

Sign in to view

1c3t3a force-pushed the sanitizer-ignorelist branch from eeed708 to 066c9e1 Compare August 27, 2026 10:17

1c3t3a requested a review from rcvalle August 27, 2026 10:18

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2026

jakos-sec reviewed Aug 27, 2026

View reviewed changes

Comment thread tests/codegen-llvm/sanitizer/ignorelist/ignorelist.txt Outdated

This comment has been minimized.

Sign in to view

1c3t3a force-pushed the sanitizer-ignorelist branch from 3f6de90 to 1cb8361 Compare August 27, 2026 16:30

This comment has been minimized.

Sign in to view

1c3t3a force-pushed the sanitizer-ignorelist branch from 1cb8361 to a9e36d5 Compare August 28, 2026 08:59

This comment has been minimized.

Sign in to view

1c3t3a added 11 commits August 31, 2026 16:16

Refactor type_name_for_ignore_list into its own method

ea0149d

Refactor when tipeid is computed

2877632

Move is_sanitizer_type_ignored to the context

8057caa

Move shared code to rustc_sanitizers crate and reorg tests

c67d9c2

Always emit type metadata for CFI and KCFI

e622526

sanitizers: track SpecialCaseList blame to resolve ignorelist overrides

a4db314

sanitizers: support Clang section names and glob expansion in ignorelist

70900a4

Reformat C++ code

df8b887

sanitizers: do not fall back to [address] for kernel sanitizer functions

f071cb7

In Clang, falling back to [address] for kernel-address (and [hwaddress] for kernel-hwaddress) only applies to global variables, not functions. Update function ignorelist filtering to match Clang.

1c3t3a force-pushed the sanitizer-ignorelist branch from a9e36d5 to f071cb7 Compare August 31, 2026 16:17

This comment has been minimized.

Sign in to view

1c3t3a force-pushed the sanitizer-ignorelist branch from 4d27534 to 40db0f2 Compare August 31, 2026 17:43

This comment has been minimized.

Sign in to view

sanitizers(tests): split shared ignorelist.txt into per-test files an…

2f2945e

…d drop safestack

1c3t3a force-pushed the sanitizer-ignorelist branch from 40db0f2 to 2f2945e Compare August 31, 2026 18:33

dingxiangfei2009 reviewed Aug 31, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_llvm/src/consts.rs Outdated

dingxiangfei2009 reviewed Aug 31, 2026

View reviewed changes

Comment thread compiler/rustc_sanitizers/src/ignorelist/ffi.rs Outdated

React to review comments

e9d998f

dingxiangfei2009 reviewed Aug 31, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

1c3t3a commented Jun 12, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 12, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Aug 27, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Aug 31, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

dingxiangfei2009 Aug 31, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

1c3t3a Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dingxiangfei2009 Aug 31, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

1c3t3a Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

1c3t3a Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

1c3t3a commented Jun 12, 2026 •

edited by rustbot

Loading

dingxiangfei2009 Aug 31, 2026 •

edited by rustbot

Loading

dingxiangfei2009 Aug 31, 2026 •

edited by rustbot

Loading