Preserve ambiguous glob lint for subtrait method picks - #157968
Merged
rust-bors[bot] merged 1 commit intoAug 30, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
The fix does not look unreasonable. Maybe someone familiar with the code can easily determine if this is the right fix. The changed code was added in #149058, so I'd like to CC PR author @LorrensP-2158466 and PR reviewer @petrochenkov. |
LorrensP-2158466
approved these changes
Aug 5, 2026
fmease
reviewed
Aug 23, 2026
fmease
force-pushed
the
fix/issue-157965-ambiguous-glob-subtrait
branch
from
August 29, 2026 17:29
62c5646 to
d44d827
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
fmease
approved these changes
Aug 29, 2026
Member
There was a problem hiding this comment.
Thanks! I did apply some small changes myself:
- rebased past #152225
- dropped
#![allow(dead_code, unused_imports)]from the test sincecompiletestimplicitly adds-Aunused - dropped
//@ check-failfrom the test since it's the default mode - dropped
//@ normalize-stderr: "error: aborting due to 1 previous error\n\n" -> "error: aborting due to 1 previous error\n"from the test since there's no need whatsoever to normalize away the extra newline - added
// issue: <https://github.com/rust-lang/rust/issues/157965>to the test
@bors r+ rollup
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
…iguous-glob-subtrait, r=fmease Preserve ambiguous glob lint for subtrait method picks Fixes rust-lang#157965
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
…iguous-glob-subtrait, r=fmease Preserve ambiguous glob lint for subtrait method picks Fixes rust-lang#157965
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 29, 2026
Rollup of 7 pull requests Successful merges: - #160941 (Enforce safety comments on `alloc`) - #161975 (Abort instead of unwinding out of an inconsistent BTreeMap::split_off) - #157968 (Preserve ambiguous glob lint for subtrait method picks) - #161514 (rework handling of doc attributes on macro calls) - #161944 (rustdoc: Take into account edition information for keyword highlighting) - #161974 (remove rustc_never_type_options attr remnants) - #161978 (Move rustdoc ui doctests into the right testsuite) Failed merges: - #161702 (Use `drop_guard` in some places in {core,alloc,std})
lcnr
added
the
relnotes
Member
|
@lcnr I'm not sure I understand why you've tagged this with
relnotes
|
fmease
removed
the
relnotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157965