Skip to content

[stable] 1.98.1 release - #161555

Merged
rust-bors[bot] merged 5 commits into
rust-lang:stablefrom
lcnr:backport-erased-handling
Sep 1, 2026
Merged

[stable] 1.98.1 release#161555
rust-bors[bot] merged 5 commits into
rust-lang:stablefrom
lcnr:backport-erased-handling

Conversation

@lcnr

@lcnr lcnr commented Aug 22, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

Backport of "rerun in original typing mode if we meet any opaques in post analysis" #158993 to stable, fixes #161441

We didn't notice that a beta cutoff happened between #156742 and #158993 and it's easy to forget that we need to be careful with next-solver bugs as they can affect stable via coherence and impossible_predicates.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 22, 2026
@rustbot

rustbot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 19 candidates

@rustbot

This comment has been minimized.

Sign in to view
@lcnr lcnr changed the title Backport erased handling backport "rerun in original typing mode if we meet any opaques in post analysis" to stable Aug 22, 2026
@lcnr lcnr added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Aug 22, 2026
@lcnr lcnr mentioned this pull request Aug 22, 2026
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Aug 22, 2026
@lcnr

lcnr commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

no idea if this is correct for a stable backport xd

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lcnr
lcnr force-pushed the backport-erased-handling branch from 0237223 to c10713e Compare August 23, 2026 06:57
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@jieyouxu jieyouxu mentioned this pull request Aug 24, 2026
Merged
@cuviper

cuviper commented Aug 24, 2026

Copy link
Copy Markdown
Member

no idea if this is correct for a stable backport xd

Normally we would just label the original PR and discuss from there, but that's ok.

Did the object test come from a different PR?

@lcnr

lcnr commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

the object test is from #161441.

#158993 was already merged on beta by then. So we don't have that test in our test suite (yet)

meta-codesync Bot pushed a commit to facebook/Lifeguard that referenced this pull request Aug 25, 2026
@capickett @meta-codesync
Back out "Update platform010 & platform010-aarch64 symlinks"
c6e256f 
Summary:
D117423626 rust-lang/rust#161441

Miscompilation on 1.98.0 stable, waiting for PR rust-lang/rust#161555 before 1.98.1 release.

In the meantime, revert the 1.98.0 bump and wait.

Reviewed By: dtolnay

Differential Revision: D117431620

fbshipit-source-id: 7f93e5654ba6c2783e7411df47b62a1c3fdcc32c
meta-codesync Bot pushed a commit to facebookincubator/buck2-change-detector that referenced this pull request Aug 25, 2026
@capickett @meta-codesync
Back out "Update platform010 & platform010-aarch64 symlinks"
05c5477 
Summary:
D117423626 rust-lang/rust#161441

Miscompilation on 1.98.0 stable, waiting for PR rust-lang/rust#161555 before 1.98.1 release.

In the meantime, revert the 1.98.0 bump and wait.

Reviewed By: dtolnay

Differential Revision: D117431620

fbshipit-source-id: 7f93e5654ba6c2783e7411df47b62a1c3fdcc32c
meta-codesync Bot pushed a commit to facebook/ocamlrep that referenced this pull request Aug 25, 2026
@capickett @meta-codesync
Back out "Update platform010 & platform010-aarch64 symlinks"
eef4420 
Summary:
D117423626 rust-lang/rust#161441

Miscompilation on 1.98.0 stable, waiting for PR rust-lang/rust#161555 before 1.98.1 release.

In the meantime, revert the 1.98.0 bump and wait.

Reviewed By: dtolnay

Differential Revision: D117431620

fbshipit-source-id: 7f93e5654ba6c2783e7411df47b62a1c3fdcc32c
meta-codesync Bot pushed a commit to facebookincubator/reindeer that referenced this pull request Aug 25, 2026
@capickett @meta-codesync
Back out "Update platform010 & platform010-aarch64 symlinks"
e054937 
Summary:
D117423626 rust-lang/rust#161441

Miscompilation on 1.98.0 stable, waiting for PR rust-lang/rust#161555 before 1.98.1 release.

In the meantime, revert the 1.98.0 bump and wait.

Reviewed By: dtolnay

Differential Revision: D117431620

fbshipit-source-id: 7f93e5654ba6c2783e7411df47b62a1c3fdcc32c
meta-codesync Bot pushed a commit to facebook/buck2 that referenced this pull request Aug 25, 2026
@capickett @meta-codesync
Back out "Update platform010 & platform010-aarch64 symlinks"
b120f8c 
Summary:
D117423626 rust-lang/rust#161441

Miscompilation on 1.98.0 stable, waiting for PR rust-lang/rust#161555 before 1.98.1 release.

In the meantime, revert the 1.98.0 bump and wait.

Reviewed By: dtolnay

Differential Revision: D117431620

fbshipit-source-id: 7f93e5654ba6c2783e7411df47b62a1c3fdcc32c
meta-codesync Bot pushed a commit to meta-pytorch/monarch that referenced this pull request Aug 26, 2026
@capickett @meta-codesync
Back out "Update platform010 & platform010-aarch64 symlinks"
19afa7c 
Summary:
D117423626 rust-lang/rust#161441

Miscompilation on 1.98.0 stable, waiting for PR rust-lang/rust#161555 before 1.98.1 release.

In the meantime, revert the 1.98.0 bump and wait.

Reviewed By: dtolnay

Differential Revision: D117431620

fbshipit-source-id: 7f93e5654ba6c2783e7411df47b62a1c3fdcc32c
@jieyouxu jieyouxu closed this Aug 26, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2026
@jieyouxu jieyouxu reopened this Aug 26, 2026
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 31, 2026
@rust-bors

rust-bors Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

💔 Test for e9727ee failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@theemathas

theemathas commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@bors retry

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 31, 2026
@bors
Auto merge of #161555 - lcnr:backport-erased-handling, r=Mark-Simulacrum
5793c24 
[stable] 1.98.1 release



Backport of "rerun in original typing mode if we meet any opaques in post analysis" #158993 to stable, fixes #161441

We didn't notice that a beta cutoff happened between #156742 and #158993 and it's easy to forget that we need to be careful with next-solver bugs as they can affect stable via coherence and `impossible_predicates`.
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 31, 2026
@rust-bors

rust-bors Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 5793c24 failed: CI. Failed job:

@cuviper

cuviper commented Aug 31, 2026

Copy link
Copy Markdown
Member

That looks like the cache problem that I hit on beta #161422 too:
https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/GCC.20broken.20tests.20passed.20auto.20CI/near/619144057

... and I ultimately had to give that a unique cache-busting value (beta-1) before it would pass.

@Kobzol @Mark-Simulacrum
Bust sccache's cache
4014df6 
(cherry picked and altered to random value from commit 93a81b4)
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2026
@Mark-Simulacrum

Mark-Simulacrum commented Aug 31, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup=never p=100

@rust-bors

rust-bors Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 4014df6 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 31, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 1, 2026
@bors
Auto merge of #161555 - lcnr:backport-erased-handling, r=Mark-Simulacrum
4ec7df2 
[stable] 1.98.1 release



Backport of "rerun in original typing mode if we meet any opaques in post analysis" #158993 to stable, fixes #161441

We didn't notice that a beta cutoff happened between #156742 and #158993 and it's easy to forget that we need to be careful with next-solver bugs as they can affect stable via coherence and `impossible_predicates`.
@JonathanBrouwer

JonathanBrouwer commented Sep 1, 2026

Copy link
Copy Markdown
Member

Not gonna finish in time, let's retry
@bors cancel

@rust-bors

rust-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #161555.

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2026
@rust-bors

rust-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: Mark-Simulacrum
Duration: 5h 30m 32s
Pushing 48a229c to stable...

@rust-bors
rust-bors Bot merged commit 48a229c into rust-lang:stable Sep 1, 2026
14 checks passed
@rustbot rustbot added this to the 1.98.1 milestone Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

merged-by-bors This PR was explicitly merged by bors. stable-accepted Accepted for backporting to the compiler in the stable channel. stable-nominated Nominated for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.98.1

Development

Successfully merging this pull request may close these issues.