add `Complex` ABI run-make test by folkertdev · Pull Request #161694 · rust-lang/rust

folkertdev · 2026-08-24T19:21:08Z

tracking issue: #154023

Just some back and forth between C and Rust, as a first line of defense against ABI mismatches. Something like abi-cafe is better because it just tests more scenarios than we reasonably can here, but now we run something on CI at least.

folkertdev · 2026-08-24T19:21:36Z

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-*,arm-android

add `Complex` ABI run-make test try-job: test-various try-job: aarch64-apple-* try-job: *-gnu-nopt-* try-job: x86_64-mingw-* try-job: aarch64-msvc-* try-job: arm-android

rust-bors · 2026-08-24T22:07:19Z

💔 Test for a897fb9 failed: CI. Failed jobs:

try - aarch64-apple-1 (web logs, enhanced plaintext logs)
try - aarch64-apple-macos-26-1 (web logs, enhanced plaintext logs)
try - aarch64-msvc-1 (web logs, enhanced plaintext logs)

folkertdev · 2026-08-25T18:37:44Z

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-*,arm-android

add `Complex` ABI run-make test try-job: test-various try-job: aarch64-apple-* try-job: *-gnu-nopt-* try-job: x86_64-mingw-* try-job: aarch64-msvc-* try-job: arm-android

folkertdev · 2026-08-25T19:53:57Z

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-*,arm-android

add `Complex` ABI run-make test try-job: test-various try-job: aarch64-apple-* try-job: *-gnu-nopt-* try-job: x86_64-mingw-* try-job: aarch64-msvc-* try-job: arm-android

rust-bors · 2026-08-25T22:41:23Z

💔 Test for 6467fdd failed: CI. Failed jobs:

try - aarch64-apple-1 (web logs, enhanced plaintext logs)
try - aarch64-apple-macos-26-1 (web logs, enhanced plaintext logs)

folkertdev · 2026-08-25T22:51:50Z

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-*,arm-android

add `Complex` ABI run-make test try-job: test-various try-job: aarch64-apple-* try-job: *-gnu-nopt-* try-job: x86_64-mingw-* try-job: aarch64-msvc-* try-job: arm-android

rust-bors · 2026-08-26T01:22:31Z

☀️ Try build successful (CI)
Build commit: b1df54a (b1df54ab6df9bedeef96a0f94e4dd2e3ed9d73b9)
Base parent: 787af2b (787af2b8c80638c51a4fc8e44f84e6891f243ec7)

rustbot · 2026-09-02T10:04:38Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

folkertdev · 2026-09-02T10:06:01Z

the sync from #162119 should have fixed that armhf issue.

@bors try jobs=armhf-gnu

add `Complex` ABI run-make test try-job: armhf-gnu

rust-bors · 2026-09-02T11:39:20Z

☀️ Try build successful (CI)
Build commit: 7e1279f (7e1279f2f1b93c206fcab6febbfc0bfdd165d4c7)
Base parent: c25253f (c25253fac451fff60fb5b6c0b2c64d60f628c7cd)

folkertdev · 2026-09-02T11:40:37Z

@bors r=JohnTitor

rust-bors · 2026-09-02T11:40:40Z

📌 Commit c80b2bf has been approved by JohnTitor

It is now in the queue for this repository.

…=JohnTitor add `Complex` ABI run-make test tracking issue: rust-lang#154023 Just some back and forth between C and Rust, as a first line of defense against ABI mismatches. Something like abi-cafe is better because it just tests more scenarios than we reasonably can here, but now we run something on CI at least.

Zalathar · 2026-09-02T13:28:57Z

Failed in rollup in test-various: #162189 (comment)

@bors r-

rust-bors · 2026-09-02T13:29:06Z

This pull request was unapproved.

This PR was contained in a rollup (#162189), which was unapproved.

View changes since this unapproval

folkertdev · 2026-09-02T20:06:56Z

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-,i686-msvc-,arm-android,armhf-gnu

add `Complex` ABI run-make test try-job: test-various try-job: aarch64-apple-* try-job: *-gnu-nopt-* try-job: x86_64-mingw-* try-job: aarch64-msvc-* try-job: i686-msvc-* try-job: arm-android try-job: armhf-gnu

rust-bors · 2026-09-02T23:21:28Z

☀️ Try build successful (CI)
Build commit: 9624189 (9624189386498e7c4819290f358ad2d4016f4289)
Base parent: 824336a (824336ad4127ce295849937a24c08a4aeff6ada7)

folkertdev · 2026-09-02T23:23:57Z

@bors rollup=iffy

@bors r=JohnTitor

rust-bors · 2026-09-02T23:24:00Z

📌 Commit b13c235 has been approved by JohnTitor

It is now in the queue for this repository.

…=JohnTitor add `Complex` ABI run-make test tracking issue: rust-lang#154023 Just some back and forth between C and Rust, as a first line of defense against ABI mismatches. Something like abi-cafe is better because it just tests more scenarios than we reasonably can here, but now we run something on CI at least.

Rollup of 29 pull requests Successful merges: - #161694 (add `Complex` ABI run-make test) - #162014 (Move more `rustdoc-html` tests using `--test` into the right folder) - #162164 (Revert "Implement Debug for C-like enums with a concatenated string") - #160564 (volatile: allow accesses to non-AM memory to trap) - #161579 (suggest calling a fn item used as the iterator of a `for` loop) - #162044 (coverage: Resolve spans to file-coordinates in a separate step) - #162120 (Introduce `PerOwnerLoweringState`) - #162132 (std: improve safety documentation in UNIX stack overflow code) - #162151 (Test itanium mangling of `f16` and `f128`) - #162162 (Don't special-case `!` in stability checks anymore) - #162181 (Remove wrong UnusedBraces lint for iterator loop in edition 2024 ) - #162187 (Rename `thir::ExprKind::Use` to `ValueExpr`) - #158401 (mgca: Don't ICE when evaluating ValTrees that contain error constants) - #159873 (fuchsia: Add safestack as a supported sanitizer for x86_64 fuchsia) - #161847 (Preserve visibility in nested macro import suggestions) - #161951 (Windows: add fallback if `canonicalize` fails) - #161972 (Improve tests for `#[track_caller]` in async) - #162008 (Render the `box` pattern removal diagnostic more actionable & remove `box` expression recovery) - #162065 (std: don't reference `libc::O_NOFOLLOW` on VxWorks in `set_perm_nofollow`) - #162076 (docs(num): clarify conditions under which error occurs in `impl TryFrom<int> for int`) - #162152 (Revert "retrieve supported GCC targets from the sysroot") - #162153 (Prefer `LLVMGetVersion` for runtime info) - #162168 (fix ICE in project_goals/inherent) - #162171 (Explain LoongArch f16 NaN-boxing in inline asm) - #162173 (fix supposedly unreachable `bug!` being reachable) - #162180 (remove outdated next-solver FIXMEs) - #162191 (core: mark float `ClampBounds` methods as `#[inline]`) - #162195 (docs(time): clarify exact seconds for week and day) - #162199 (docs(time): clarify exact seconds for hour and minute)

…=JohnTitor add `Complex` ABI run-make test tracking issue: rust-lang#154023 Just some back and forth between C and Rust, as a first line of defense against ABI mismatches. Something like abi-cafe is better because it just tests more scenarios than we reasonably can here, but now we run something on CI at least.

folkertdev added the F-complex_numbers `#![feature(complex_numbers)]` label Aug 24, 2026

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2026

This comment has been minimized.

Sign in to view

folkertdev force-pushed the complex-abi-run-make branch 2 times, most recently from 9dfa414 to c8d5ba7 Compare August 25, 2026 18:29

This comment has been minimized.

Sign in to view

folkertdev force-pushed the complex-abi-run-make branch from c8d5ba7 to d8cf4ed Compare August 25, 2026 19:23

This comment has been minimized.

Sign in to view

folkertdev force-pushed the complex-abi-run-make branch from d8cf4ed to 2186035 Compare August 25, 2026 22:13

This comment has been minimized.

Sign in to view

folkertdev marked this pull request as ready for review August 27, 2026 10:38

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2026

rustbot assigned JohnTitor Aug 27, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 2, 2026

Auto merge of #161694 - folkertdev:complex-abi-run-make, r=<try>

7e1279f

add `Complex` ABI run-make test try-job: armhf-gnu

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 2, 2026

Zalathar mentioned this pull request Sep 2, 2026

Rollup of 18 pull requests #162189

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2026

add Complex abi run-make test

b13c235

folkertdev force-pushed the complex-abi-run-make branch from c80b2bf to b13c235 Compare September 2, 2026 20:04

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 2, 2026

Zalathar mentioned this pull request Sep 3, 2026

Rollup of 29 pull requests #162221

Closed

JonathanBrouwer mentioned this pull request Sep 3, 2026

Rollup of 25 pull requests #162229

Open

Uh oh!

Uh oh!

Conversation

folkertdev commented Aug 24, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

folkertdev commented Aug 24, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 24, 2026

Uh oh!

folkertdev commented Aug 25, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

folkertdev commented Aug 25, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 25, 2026

Uh oh!

folkertdev commented Aug 25, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 26, 2026

Uh oh!

rustbot commented Sep 2, 2026

Uh oh!

folkertdev commented Sep 2, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 2, 2026

Uh oh!

folkertdev commented Sep 2, 2026

Uh oh!

rust-bors Bot commented Sep 2, 2026

Uh oh!

Zalathar commented Sep 2, 2026

Uh oh!

rust-bors Bot commented Sep 2, 2026

Uh oh!

folkertdev commented Sep 2, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 2, 2026

Uh oh!

folkertdev commented Sep 2, 2026

Uh oh!

rust-bors Bot commented Sep 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

folkertdev commented Aug 24, 2026 •

edited by rustbot

Loading