Skip to content

Replace builtin # with k# - #162232

Draft
fmease wants to merge 11 commits into
rust-lang:mainfrom
fmease:yeet-builtin-hash
Draft

Replace builtin # with k##162232
fmease wants to merge 11 commits into
rust-lang:mainfrom
fmease:yeet-builtin-hash

Conversation

@fmease

@fmease fmease commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Important

Stacked on top of #161775.

Part of #153839. Also renames internal feature builtin_syntax to internal_syntax (without tombstoning) and keeps/reuses tracking issue #110680.

Blocked on #161775 getting merged and picked up by stage0 rustfmt.

(No LLM was or will be used by me during the entire creation process of this PR)

@fmease fmease added S-blocked Status: Blocked on something else such as an RFC or other implementation work. rla-silenced Silences rust-log-analyzer postings to the PR it's added on. labels Sep 3, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 3, 2026
@fmease fmease removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 3, 2026
fmease
fmease commented Sep 3, 2026
View reviewed changes
Comment thread compiler/rustc_parse/src/parser/expr.rs Outdated
Comment thread compiler/rustc_span/src/symbol.rs
@fmease fmease mentioned this pull request Sep 3, 2026
Open
@rust-bors

rust-bors Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #162229) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) rla-silenced Silences rust-log-analyzer postings to the PR it's added on. S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fmease @rustbot