clean up tracing spans, fields, span-level - #149
Merged
Conversation
syphar
force-pushed
the
less-tracing-fields
branch
from
September 8, 2026 12:23
fb43d72 to
1470e51
Compare
syphar
force-pushed
the
less-tracing-fields
branch
from
September 8, 2026 12:25
1470e51 to
5b08931
Compare
syphar
marked this pull request as ready for review
September 8, 2026 12:30
Member
Author
syphar
force-pushed
the
less-tracing-fields
branch
from
September 8, 2026 12:56
2d598b0 to
811f0fe
Compare
GuillaumeGomez
approved these changes
Sep 8, 2026
Member
|
Looks good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracing was generally added mainly for
This got too much (too many span fields, too big values of these fields, too many spans).
So this PR:
level = "debug"for spans on internal functions. This reduces output on user-visible logs. By default, sentry won't see these spans too. We can re-activate this when we want.This was tested with the WIP builder-refactor / CLI.