Skip to content

clean up tracing spans, fields, span-level - #149

Merged
syphar merged 2 commits into
rust-lang:mainfrom
syphar:less-tracing-fields
Sep 8, 2026
Merged

clean up tracing spans, fields, span-level#149
syphar merged 2 commits into
rust-lang:mainfrom
syphar:less-tracing-fields

Conversation

@syphar

@syphar syphar commented Sep 3, 2026

Copy link
Copy Markdown
Member

tracing was generally added mainly for

  • performance tracing
  • add some span fields to the log-messages

This got too much (too many span fields, too big values of these fields, too many spans).

So this PR:

  • removes most span fields, re-adds only some. Will add more when needed.
  • adds some of the removed span fields to specific log-messages. Sometimes we only need the info once.
  • set level = "debug" for spans on internal functions. This reduces output on user-visible logs. By default, sentry won't see these spans too. We can re-activate this when we want.

This was tested with the WIP builder-refactor / CLI.

@syphar syphar self-assigned this Sep 3, 2026
@syphar syphar changed the title WIP: clean up tracing spans, fields, log-levels clean up tracing spans, fields, span-level Sep 8, 2026
@syphar
syphar force-pushed the less-tracing-fields branch from fb43d72 to 1470e51 Compare September 8, 2026 12:23
@syphar
syphar force-pushed the less-tracing-fields branch from 1470e51 to 5b08931 Compare September 8, 2026 12:25
@syphar
syphar marked this pull request as ready for review September 8, 2026 12:30
@syphar

syphar commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

r? @GuillaumeGomez

Comment thread src/cmd/mod.rs Outdated
Comment thread src/cmd/mod.rs Outdated
@syphar
syphar merged commit 8862238 into rust-lang:main Sep 8, 2026
2 of 11 checks passed
@GuillaumeGomez

Copy link
Copy Markdown
Member

Looks good to me, thanks!

@syphar
syphar deleted the less-tracing-fields branch September 8, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants