Various improvements to team member validation - #2703
Conversation
607fc1e to
56ea82b
Compare
Dry-run check results |
6be2d62 to
bb746a7
Compare
|
By running the overlap check only on the already individually-deduplicated list of members+alumni, something like e.g. a duplicate alumni won't result in a sequence of multiple of error messages as it currently does before after The choice of |
This comment has been minimized.
This comment has been minimized.
|
Prepending a revert commit of #2701 and rebasing to remove the merge conflict. |
bb746a7 to
cf2f39f
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
All code that #2701 (or its revert) touches are changed here anyway, so I might as well squash it then. |
- refactor the duplication check - add checks for duplicate roles - check against invalid roles of alumni
cf2f39f to
bf4521d
Compare
supersedes both #2701 and #2702