feat(cosi): foundation admin client + CAS grant ownership - #219
Open
BenjaminFuentesEviden wants to merge 6 commits into
Open
feat(cosi): foundation admin client + CAS grant ownership#219BenjaminFuentesEviden wants to merge 6 commits into
BenjaminFuentesEviden wants to merge 6 commits into
Conversation
Extract shared rustfs-admin client, ship a tonic COSI driver with Helm toggle, and document BucketClass parameters for Tenant-backed S3. Co-authored-by: Cursor <cursoragent@cursor.com>
Align DriverGrantBucketAccess with Ceph-style isolation: deterministic secrets, never rotate existing users, and return AlreadyExists when preferredAccessKey is claimed by another BucketAccess. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace derivable secrets and marker-based IAM ownership with durable random credentials plus PendingCreate/Ready checkpoints so concurrent preferredAccessKey grants conflict safely and external BAC policies are never overwritten. Split the COSI driver into thin gRPC adapters over testable grant/bucket state machines. Co-authored-by: Cursor <cursoragent@cursor.com>
Existence probes and test fixtures often return an empty 200; treat that as an existing user with no policies instead of failing the parse. Co-authored-by: Cursor <cursoragent@cursor.com>
16 tasks
Author
|
@GatewayJ I applied the first PR here that is mainly impacting the code split you asked, once validated, I will add the extras on a next PR B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
Foundation PR A (COSI+Helm / sidecar pin stay in PR B):
crates/rustfs-admin— kube-agnostic HTTP/admin/S3/STS client shared byoperatorandrustfs-cosi-driver(operator keeps Tenant credential loading wrappers).cosi-cred-{grant}beforeadd_user; retries reuse the Secret (never re-derive from access key).rustfs-cosi-ownershipcheckpointsPendingCreate→Ready(proof: grant_name, account_id, access_key_hash, cred_secret_name, state). ConcurrentpreferredAccessKeyconflicts; orphan RustFS users are not adopted.cosi-pol-{grant}; BACpolicyparam is validate/attach only (neveradd_canned_policyreplace).grant/bucketmodules; staticbucketName/bucketsdeletes return FailedPrecondition.Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](if user-visible change)Impact
Verification
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.