"NearbyFactionGoodwill" and "TradeRequest" fixes - #984
Open
still222 wants to merge 1 commit into
Open
Conversation
still222
marked this pull request as ready for review
August 19, 2026 08:14
Contributor
Author
|
Once again, I tested it as an external patch because of the problem with compilations (see #983 (comment)). Should be good but still. |
notfood
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 tiny patches to ensure that ritual reward and quest can target correct (meaningful) factions.
While "NearbyFactionGoodwill" is a pure fix of a bug, "TradeRequest" patch is more complicated.
I learned that trade request from another player faction indeed works. But it dilutes rewards pool from real factions, and doesnt make much sense. I commented about 50 kids pants quest in exchange for legendary LMG... neither of which exist/appear on that player settlement).