Make Screen Edge Gap setting editable in UI - #1838
Closed
rutgerkraaijer wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks for contributing!
That should make things more clear and reduce space. |
Owner
|
I was thinking about this a little more, and I think I'll go ahead and roll in the screen edge gaps settings for all edges, and put it directly on the General tab. I'll keep your "only on the main screen" setting, though. Apologies on declining this, but I appreciate you posting it and exposing a desired path! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use the currently hidden
screenEdgeGapRightandscreenEdgeGapsOnMainScreenOnlysettings to keep the notification area clear at all times. Since hidden settings aren't particularly user-friendly, this PR aims to make this feature more easily accessible and manageable.What this PR changes:
screenEdgeGapRightEnabledsetting, defaulting to false.screenEdgeGapsOnMainScreenOnlysetting default to true.screenEdgeGapRightEnabled,screenEdgeGapsOnMainScreenOnly, and set the value ofscreenEdgeGapRight.I've intentionally limited this change to the right edge gap, since that has a clear use case. There is an argument that the other sides could be exposed in the same way as well of course.